This repository was archived by the owner on Nov 15, 2023. It is now read-only.
AccountTouch trait: deposit_required accepts asset id#14147
Merged
paritytech-processbot[bot] merged 1 commit intomasterfrom May 15, 2023
Merged
AccountTouch trait: deposit_required accepts asset id#14147paritytech-processbot[bot] merged 1 commit intomasterfrom
paritytech-processbot[bot] merged 1 commit intomasterfrom
Conversation
muharem
added
A0-please_review
gilescope
approved these changes
May 15, 2023
Contributor
gilescope
left a comment
gilescope
left a comment
There was a problem hiding this comment.
Thank you. This gives the implementer enough information to potentially change the deposit dependent on the information contained within the asset id.
jsidorenko
approved these changes
May 15, 2023
Contributor
Author
|
bot merge |
Contributor
|
We can take off the brakes API label as the api was only merged in a week ago, and no new polkadot branches or monthly branches have been created so that api has not yet been released so this is not a breaking change in and of itself. |
EgorPopelyaev
pushed a commit
that referenced
this pull request
May 16, 2023
muharem
removed
the
F3-breaks_API
Contributor
Author
removed |
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deposit_requiredaccepts an asset id to determine a required deposit.