chore: update libp2p to 0.52.1 by melekes · Pull Request #14429 · paritytech/substrate

melekes · 2023-06-21T11:33:03Z

changelog: https://github.com/libp2p/rust-libp2p/releases/tag/libp2p-v0.52.0

polkadot companion: paritytech/polkadot#7472
cumulus companion: paritytech/cumulus#2838

also LocalProtocolsChange and RemoteProtocolsChange

also fix pending_events

See libp2p/rust-libp2p#3885

also use `Behaviour::with_codec`

rename ConnectionHandlerUpgrErr to StreamUpgradeError

melekes · 2023-06-29T12:41:35Z

client/network/src/service.rs

 					};
 					let reason = match cause {
 						Some(ConnectionError::IO(_)) => "transport-error",
+						// Some(ConnectionError::Handler(Either::Left(Either::Left(


no such variant seems to exist

PingFailure doesn't exist?

What does ConnectionError::Handler(Either::Left(Either::Left(Either::Left(Either::Right contain?

let reason = match cause { | ----- this expression has type `std::option::Option<ConnectionError<either::Either<either::Either<either::Either<either::Either<NotifsHandlerError, either::Either<void::Void, std::io::Error>>, std::io::Error>, void::Void>, void::Void>>>`

std::io::Error

If we are sure that this io::Error is handling the case for ping failure, may be we should still report it as "ping-failure" and not as default "protocol-error"?

client/network/src/service.rs

See https://github.com/libp2p/rust-libp2p/blob/master/protocols/identify/CHANGELOG.md#0430

in attempt to compile polkadot

in attempt to build cumulus

altonen · 2023-07-20T16:00:14Z

client/network/src/discovery.rs

+				// Set the Kademlia mode to server so that it can accept incoming requests.
+				//
+				// Note: the server mode is set automatically when the node learns its external
+				// address, but that does not happen in tests => hence we set it manually.


How about another test with one server and one client, just to verify that such a scenario also works?

altonen · 2023-07-20T16:05:10Z

client/network/src/protocol/notifications/handler.rs

+	// 		};
+
+	// 		handler.on_connection_event(handler::ConnectionEvent::FullyNegotiatedInbound(
+	// 			handler::FullyNegotiatedInbound { protocol: (notif_in, 0), info: () },


@thomaseizinger

IIUC the reason these were commented out was because something in libp2p was made private. What was the exact reason @melekes?

thomaseizinger · 2023-07-20T17:46:39Z

While this is not my problem anymore, I find it frustrating that every update of a libp2p version seems to require a +1000 -1000 pull request that understandably takes a long time to write, review, and merge.

I find it a bit ridiculous that a very critical feature is blocked on a simple version bump, but this simple version bump comes bundles with tons of breaking changes.

You will appreciate then that lots of engineering hours have already gone and will continue to go into making as few breaking changes as possible:

You can discover more things by following the links in the above issues. Esp. the 0.52 release hardened many many APIs in rust-libp2p that allow us to make improvements without making more breaking changes :)

kpp · 2023-07-24T10:26:00Z

client/network/src/discovery.rs

+				self.kademlia.on_swarm_event(FromSwarm::NewListenAddr(e));
+
+				if let Some(ref mut mdns) = self.mdns {
+					mdns.on_swarm_event(FromSwarm::NewListenAddr(e));


We can use libp2p_swarm::behaviour::toggle::Toggle instead of Option<TokioMdns>. It will remove ifs because they are hidden inside Toggle::on_* methods.

Good idea 👍 Will do in a separate PR

melekes · 2023-07-25T11:00:37Z

bot merge

paritytech-processbot · 2023-07-25T11:00:45Z

Error: Github API says paritytech/cumulus#2838 is not mergeable

melekes · 2023-07-25T11:11:22Z

bot merge

paritytech-processbot · 2023-07-25T11:11:30Z

Error: "Check reviews" status is not passing for paritytech/cumulus#2838

melekes · 2023-07-25T11:12:14Z

bot merge

refs paritytech#14429 (comment)

refs #14429 (comment)

This reverts commit d38d176.

* Revert "chore: update libp2p to 0.52.1 (#14429)" This reverts commit d38d176. * Fix dependencies * Update dependencies * Update Cargo.lock

update libp2p to 0.52.0

3102dbd

melekes added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 21, 2023

melekes self-assigned this Jun 21, 2023

melekes added 19 commits June 21, 2023 16:25

proto name now must implement AsRef<str>

54778bd

update libp2p version everywhere

839641b

ToSwarm, FromBehaviour, ToBehaviour

45ff813

also LocalProtocolsChange and RemoteProtocolsChange

new NetworkBehaviour invariants

12ba133

replace Vec<u8> with StreamProtocol

fe656e8

rename ConnectionHandlerEvent::Custom to NotifyBehaviour

37e7408

remove DialError & ListenError invariants

d5b8198

also fix pending_events

use connection_limits::Behaviour

81f5cd0

See libp2p/rust-libp2p#3885

impl void::Void for BehaviourOut

4d068dd

also use `Behaviour::with_codec`

KademliaHandler no longer public

3e54dd1

fix StreamProtocol construction

076635b

update libp2p-identify to 0.2.0

d1fd05c

remove non-existing methods from PollParameters

f01de8b

rename ConnectionHandlerUpgrErr to StreamUpgradeError

P2p now contains PeerId, not Multihash

bea250f

use multihash-codetable crate

405ebcb

Merge branch 'master' into anton/libp2p-0.52.0

394eba1

update Cargo.lock

ac5cfd3

reformat text

3d04207

comment out tests for now

5f511cc

melekes commented Jun 29, 2023

View reviewed changes

client/network/src/service.rs Outdated Show resolved Hide resolved

melekes added 4 commits June 29, 2023 17:15

Merge branch 'master' into anton/libp2p-0.52.0

f141f03

remove .into() from P2p

6970c11

confirm observed addr manually

49e0ba7

See https://github.com/libp2p/rust-libp2p/blob/master/protocols/identify/CHANGELOG.md#0430

Merge branch 'master' into anton/libp2p-0.52.0

477ebc1

melekes added 2 commits July 19, 2023 10:39

Merge branch 'master' into anton/libp2p-0.52.0

c34f538

update smallvec and sha2

d44efb5

in attempt to compile polkadot

melekes requested review from a team July 19, 2023 06:43

melekes added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Jul 19, 2023

This comment was marked as resolved.

Sign in to view

bump k256

ff76e2a

in attempt to build cumulus

melekes mentioned this pull request Jul 20, 2023

make noise transport perform less reallocations libp2p/rust-libp2p#4221

Closed

sam0x17 approved these changes Jul 20, 2023

View reviewed changes

altonen approved these changes Jul 20, 2023

View reviewed changes

kpp reviewed Jul 24, 2023

View reviewed changes

Merge branch 'master' into anton/libp2p-0.52.0

925cad0

paritytech-processbot bot merged commit d38d176 into paritytech:master Jul 25, 2023

melekes deleted the anton/libp2p-0.52.0 branch July 25, 2023 11:12

melekes added a commit to melekes/substrate that referenced this pull request Jul 28, 2023

use Toggle instead of Option for mdns

a2d2947

refs paritytech#14429 (comment)

melekes added a commit to melekes/substrate that referenced this pull request Jul 28, 2023

use Toggle instead of Option for mdns

3b0ebfb

refs paritytech#14429 (comment)

melekes mentioned this pull request Jul 28, 2023

use Toggle instead of Option for mdns #14667

Merged

paritytech-processbot bot pushed a commit that referenced this pull request Jul 31, 2023

use Toggle instead of Option for mdns (#14667)

1d13511

refs #14429 (comment)

melekes mentioned this pull request Aug 2, 2023

[network] fix: always set Kademlia mode to server #14703

Merged

altonen added a commit that referenced this pull request Aug 5, 2023

Revert "chore: update libp2p to 0.52.1 (#14429)"

aa88ec7

This reverts commit d38d176.

altonen added a commit that referenced this pull request Aug 6, 2023

Revert "chore: update libp2p to 0.52.1 (#14429)"

5c44677

This reverts commit d38d176.

altonen added a commit that referenced this pull request Aug 6, 2023

Revert "chore: update libp2p to 0.52.1 (#14429)"

4128455

This reverts commit d38d176.

Ank4n pushed a commit that referenced this pull request Aug 20, 2023

Revert "chore: update libp2p to 0.52.1 (#14429)" (#14722)

7071c60

* Revert "chore: update libp2p to 0.52.1 (#14429)" This reverts commit d38d176. * Fix dependencies * Update dependencies * Update Cargo.lock

Conversation

melekes commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as resolved.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thomaseizinger commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melekes commented Jul 25, 2023

Uh oh!

paritytech-processbot bot commented Jul 25, 2023

Uh oh!

melekes commented Jul 25, 2023

Uh oh!

paritytech-processbot bot commented Jul 25, 2023

Uh oh!

melekes commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

melekes commented Jun 21, 2023 •

edited

Loading

thomaseizinger commented Jul 20, 2023 •

edited

Loading