This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[network] fix: always set Kademlia mode to server#14703
Merged
altonen merged 1 commit intoparitytech:masterfrom Aug 3, 2023
Merged
[network] fix: always set Kademlia mode to server#14703altonen merged 1 commit intoparitytech:masterfrom
altonen merged 1 commit intoparitytech:masterfrom
Conversation
otherwise, connectivity drops significantly.
melekes
added
A0-please_review
dmitry-markin
approved these changes
Aug 2, 2023
Contributor
|
I have tested this PR on Versi and it seems to have fixed the connectivity issues and DHT misses. |
Contributor
|
bot rebase |
|
Branch is already up-to-date |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise, the DHT connectivity drops significantly as the graphs of our internal cluster showed.
PR where the regression was introduced: #14429