This repository was archived by the owner on Nov 15, 2023. It is now read-only.
client/network: Make NetworkService::set_priority_group async#7352
Merged
1 commit merged intoparitytech:masterfrom Oct 22, 2020
Merged
client/network: Make NetworkService::set_priority_group async#73521 commit merged intoparitytech:masterfrom
1 commit merged intoparitytech:masterfrom
Conversation
As done with `NetworkService::{add_to,remove_from}_priority_group`, make
`NetworkService::set_priority_group` async as well. This future-proofs
the API should we ever decide to use a bounded channel between
`NetworkService` and `NetworkWorker`.
mxinden
added
A0-please_review
ordian
approved these changes
Oct 21, 2020
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
LGTM.
Note, that we're not using set_priority_group in validator discovery anymore.
tomaka
approved these changes
Oct 22, 2020
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As done with
NetworkService::{add_to,remove_from}_priority_group, makeNetworkService::set_priority_groupasync as well. This future-proofsthe API should we ever decide to use a bounded channel between
NetworkServiceandNetworkWorker.See #7247 (comment) for past discussion.
Release note suggestion: