This repository was archived by the owner on Nov 15, 2023. It is now read-only.
sc-network: expose add_to_priority_group and `remove_from_priority_…#7247
Merged
9 commits merged intomasterfrom Oct 9, 2020
Merged
Conversation
…group` in `NetworkService`
ordian
added
A0-please_review
mxinden
reviewed
Oct 9, 2020
client/network/src/service.rs
Outdated
| /// | ||
| /// Returns an `Err` if one of the given addresses is invalid or contains an | ||
| /// invalid peer ID (which includes the local peer ID). | ||
| pub fn add_to_priority_group(&self, group_id: String, peers: HashSet<Multiaddr>) -> Result<(), String> { |
Contributor
There was a problem hiding this comment.
Suggested change
| pub fn add_to_priority_group(&self, group_id: String, peers: HashSet<Multiaddr>) -> Result<(), String> { | |
| pub async fn add_to_priority_group(&self, group_id: String, peers: HashSet<Multiaddr>) -> Result<(), String> { |
Declaring this method as async would grant us a greater implementation flexibility in the future, e.g. a bounded channel between NetworkService and NetworkWorker.
@tomaka what do you think of requiring all new methods on NetworkService to be able to yield?
@ordian Are you able to await this method within Polkadot?
Author
There was a problem hiding this comment.
yes, awaiting is fine, but would we need to change all three methods then (set_, add_, remove_)?
Contributor
There was a problem hiding this comment.
👍 As eventually it'd be nice if the queue from the network service to the worker was bounded as well.
…up-updates * master: Async keystore + Authority-Discovery async/await (#7000) Fixes logging of target names with dashes (#7281) seal: Add automated weights for contract API calls (#7017) add ss58 id for nodle (#7279) Refactor CurrencyToVote (#6896) bump-allocator: document & poison (#7277) Reset flaming fir network (#7274) reschedule (#6860) Drop system cache for trie benchmarks (#7242) client: improve log formatting (#7272) Rework `InspectState` (#7271) SystemOrigin trait (#7226) Update ss58 registry for Dock network (#7263) .maintain/monitoring: Add alert when continuous task ends (#7250) Rename `TRANSACTION_VERSION` to `EXTRINSIC_VERSION` (#7258) Split block announce processing into two parts (#6958) Fix offchain election to respect the weight (#7215)
Co-authored-by: Max Inden <mail@max-inden.de>
…f github.com:paritytech/substrate into ao-network-expose-incremental-priority-group-updates * 'ao-network-expose-incremental-priority-group-updates' of github.com:paritytech/substrate: Update client/network/src/service.rs
mxinden
approved these changes
Oct 9, 2020
Contributor
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Looks good to me. Small suggestion. I am fine either way.
tomaka
approved these changes
Oct 9, 2020
Co-authored-by: Max Inden <mail@max-inden.de>
Author
|
bot merge |
|
Waiting for commit status. |
|
Merge failed: |
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up to #3376 (comment).
Needed for paritytech/polkadot#1763.
polkadot companion: paritytech/polkadot#1800