Make trie_nodes_recorded_for_key work for inline values#194
Merged
Conversation
`trie_nodes_recorded_for_key` was not working properly for inline values. It would always return `RecordedForKey::None` while we actually have accessed and recorded all the trie nodes for the value. The pr introduces `TrieAccess::InlineValue` to communicate this access to the recorder properly to make it then return `RecordedForKey::Value`.
cheme
reviewed
Jun 12, 2023
Member
|
@bkchr Is this still relevant? Why do we need to record inline nodes in the first place? |
Member
Author
This is just about telling the recorder that we have seen the value. This is required when we use the cache, to be able to fetch the value from the cache. When the recorder and cache are enabled, we only fetch a value from the cache if we have recorded all the trie nodes up to this value. To be able to know if we have recorded all the trie nodes, we need to tell the recorder, also for the inline values. |
cheme
approved these changes
Sep 11, 2023
arkpar
approved these changes
Sep 12, 2023
This was referenced Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trie_nodes_recorded_for_keywas not working properly for inline values. It would always returnRecordedForKey::Nonewhile we actually have accessed and recorded all the trie nodes for the value. The pr introducesTrieAccess::InlineValueto communicate this access to the recorder properly to make it then returnRecordedForKey::Value.