Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
cheme
reviewed
Sep 12, 2023
Contributor
cheme
left a comment
There was a problem hiding this comment.
Looks good, but would also need to update trie-bench version (used by substrate) to avoid having importing two triedb version.
bkchr
approved these changes
Sep 12, 2023
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
cheme
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares the release of trie-db 0.28.0 to allow substrate paritytech/polkadot-sdk#1153 to use the merkle value functionality.
The version has been bumped from 0.27.1 to 0.28.0 since the addition of
lookup_first_descendantrepresents a breaking change for theTrietrait.Changelog
[0.28.0] - 2023-09-12
trie_nodes_recorded_for_keywork for inline values #194@paritytech/subxt-team