Skip to content

chore(deps): fix deps and organize repo#255

Merged
TarikGul merged 5 commits intomainfrom
tarik-org-deps
Sep 15, 2022
Merged

chore(deps): fix deps and organize repo#255
TarikGul merged 5 commits intomainfrom
tarik-org-deps

Conversation

@TarikGul
Copy link
Member

Since importBinary was added to @substrate/dev, we are able to clean up the deps, and run everything from @substrate/dev itself. This cleans up the deps, removes redundancy, and cleans up some configs.

@TarikGul TarikGul requested a review from a team as a code owner September 14, 2022 01:07
@TarikGul TarikGul self-assigned this Sep 14, 2022
@TarikGul TarikGul added the dependencies Pull requests that update a dependency file label Sep 14, 2022
"@types/jest": "^27.5.2",
"@typescript-eslint/eslint-plugin": "^5.30.0",
"@typescript-eslint/parser": "^5.30.0",
"eslint": "^8.18.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DQ: could this be the cause of the failing CI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea the issue here has to do with how yarn berry recursively searches and sets up the node_modules. For nested deps, there is no top level support. I think they did this for security reasons but basically we might need to either search manually ourselves or just add the dep locally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a bit annoying because it exists under @substrate/dev but isnt there at the top level.

Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be possible that the CI encountered a flaky problem.
Although it could also be an issue with the image itself not containing eslint-plugin.
Let's check it out before merging

ESLint couldn't find the plugin "@typescript-eslint/eslint-plugin".
(The package "@typescript-eslint/eslint-plugin" was not found when loaded as a Node module from the directory "/home/runner/work/txwrapper-core/txwrapper-core".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install @typescript-eslint/eslint-plugin@latest --save-dev

@TarikGul
Copy link
Member Author

It might be possible that the CI encountered a flaky problem. Although it could also be an issue with the image itself not containing eslint-plugin. Let's check it out before merging

ESLint couldn't find the plugin "@typescript-eslint/eslint-plugin".
(The package "@typescript-eslint/eslint-plugin" was not found when loaded as a Node module from the directory "/home/runner/work/txwrapper-core/txwrapper-core".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install @typescript-eslint/eslint-plugin@latest --save-dev

Okay I was able to solve the problem, I will need to do a release of substrate/dev before we do it though.

@TarikGul TarikGul requested a review from a team as a code owner September 15, 2022 14:37
@TarikGul TarikGul merged commit 27c3487 into main Sep 15, 2022
@TarikGul TarikGul deleted the tarik-org-deps branch September 15, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants