Conversation
| "@types/jest": "^27.5.2", | ||
| "@typescript-eslint/eslint-plugin": "^5.30.0", | ||
| "@typescript-eslint/parser": "^5.30.0", | ||
| "eslint": "^8.18.0", |
There was a problem hiding this comment.
DQ: could this be the cause of the failing CI?
There was a problem hiding this comment.
Yea the issue here has to do with how yarn berry recursively searches and sets up the node_modules. For nested deps, there is no top level support. I think they did this for security reasons but basically we might need to either search manually ourselves or just add the dep locally.
There was a problem hiding this comment.
Its a bit annoying because it exists under @substrate/dev but isnt there at the top level.
lexnv
left a comment
There was a problem hiding this comment.
It might be possible that the CI encountered a flaky problem.
Although it could also be an issue with the image itself not containing eslint-plugin.
Let's check it out before merging
ESLint couldn't find the plugin "@typescript-eslint/eslint-plugin".
(The package "@typescript-eslint/eslint-plugin" was not found when loaded as a Node module from the directory "/home/runner/work/txwrapper-core/txwrapper-core".)
It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm install @typescript-eslint/eslint-plugin@latest --save-dev
Okay I was able to solve the problem, I will need to do a release of substrate/dev before we do it though. |
Since
importBinarywas added to@substrate/dev, we are able to clean up the deps, and run everything from@substrate/devitself. This cleans up the deps, removes redundancy, and cleans up some configs.