Skip to content

chore(deps): fix deps and organize repo #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TarikGul merged 5 commits into from
Sep 15, 2022
Merged

chore(deps): fix deps and organize repo #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce10eae
chore(deps): fix deps and organize repo
TarikGul Sep 14, 2022
846c2d6
update substrate/dev
TarikGul Sep 14, 2022
2602ae8
test removing cache
TarikGul Sep 15, 2022
f1528f7
add cache back in
TarikGul Sep 15, 2022
c57b90c
test dedupe
TarikGul Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
${{ runner.os }}-yarn-

- name: Install JS dependencies
run: yarn install
run: yarn dedupe

- name: Build.
run: yarn build
Expand Down
2 changes: 1 addition & 1 deletion jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ module.exports = {
}),
modulePathIgnorePatterns: [
'<rootDir>/lib',
'<rootDir>/packages/txwrapper-acala/lib',
'<rootDir>/packages/txwrapper-core/lib',
'<rootDir>/packages/txwrapper-examples/lib',
'<rootDir>/packages/txwrapper-dev/lib',
'<rootDir>/packages/txwrapper-orml/lib',
'<rootDir>/packages/txwrapper-polkadot/lib',
'<rootDir>/packages/txwrapper-registry/lib',
Expand Down
17 changes: 3 additions & 14 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"deploy": "yarn run build && lerna version --conventional-commits --create-release github && lerna publish from-package",
"version": "yarn install && git stage yarn.lock",
"build": "lerna run build",
"build:workspace": "cd $INIT_CWD && rimraf lib/ && tsc -p tsconfig.build.json",
"build:workspace": "substrate-exec-rimraf $INIT_CWD/lib/ && cd $INIT_CWD && tsc -p tsconfig.build.json",
"lint": "substrate-dev-run-lint --fix",
"lint:ci": "substrate-dev-run-lint",
"test": "substrate-exec-jest",
Expand All @@ -21,27 +21,16 @@
"update-pjs-deps": "substrate-update-pjs-deps"
},
"devDependencies": {
"@babel/plugin-transform-modules-commonjs": "^7.18.6",
"@polkadot/util-crypto": "^10.1.6",
"@substrate/dev": "^0.6.3",
"@types/jest": "^27.5.2",
"@typescript-eslint/eslint-plugin": "^5.30.0",
"@typescript-eslint/parser": "^5.30.0",
"eslint": "^8.18.0",
Copy link
Contributor

@lexnv lexnv Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DQ: could this be the cause of the failing CI?

Copy link
Member Author

@TarikGul TarikGul Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea the issue here has to do with how yarn berry recursively searches and sets up the node_modules. For nested deps, there is no top level support. I think they did this for security reasons but basically we might need to either search manually ourselves or just add the dep locally.

Copy link
Member Author

@TarikGul TarikGul Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a bit annoying because it exists under @substrate/dev but isnt there at the top level.

"eslint-config-prettier": "^8.5.0",
"eslint-plugin-prettier": "^4.1.0",
"eslint-plugin-simple-import-sort": "^7.0.0",
"jest": "^27.5.1",
"@substrate/dev": "^0.6.5",
"lerna": "^4.0.0",
"prettier": "^2.7.1",
"rimraf": "^3.0.2",
"ts-jest": "^27.1.5",
"ts-node": "^9.1.1",
"tsconfig-paths": "^3.9.0",
"typedoc": "^0.22.10",
"typedoc-plugin-markdown": "^3.11.8",
"typedoc-plugin-missing-exports": "^0.22.6",
"typescript": "^4.7.4"
"typescript": "^4.8.2"
},
"packageManager": "yarn@3.2.2"
}
Loading