Potential fix for code scanning alert no. 4: Information exposure through an exception

[parkcheolhong]

Potential fix for https://github.com/parkcheolhong/codeAI/security/code-scanning/4

General fix: never include raw exception text in API responses. Log detailed exceptions on the server, and return a stable generic error code/message to clients.

Best minimal fix without changing behavior: update get_ad_queue_runtime_status() in backend/marketplace/router.py so that on RedisError it logs the exception via logger.exception(...) and sets redis_error to a generic token (for example, "redis_queue_unavailable") instead of str(exc). This preserves diagnostics shape (error field still present), keeps operational visibility in server logs, and removes sensitive information from /health and /api/health output.

Changes needed:

• File: backend/marketplace/router.py
• Region: get_ad_queue_runtime_status(), except RedisError as exc: block around lines 1062–1064.
• No new imports or dependencies required (logger already exists).

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Summary by Sourcery

Bug Fixes:

• Avoid leaking Redis exception messages in health diagnostics responses by replacing them with a stable generic error code.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR mitigates an information exposure issue in the health diagnostics endpoint by ensuring Redis exceptions are logged server-side while only a generic, non-sensitive error token is returned in the API response.

Sequence diagram for health check Redis error handling

sequenceDiagram
    actor Client
    participant ApiServer
    participant Redis
    participant Logger

    Client->>ApiServer: GET /health or /api/health
    activate ApiServer
    ApiServer->>Redis: LLEN VIDEO_RENDER_QUEUE_NAME
    alt Redis responds successfully
        Redis-->>ApiServer: queue_depth
        ApiServer->>Client: 200 OK (redis_available=true, no error)
    else RedisError raised
        Redis--xApiServer: RedisError
        ApiServer->>Logger: exception Failed to read Redis queue depth for health diagnostics
        ApiServer-->>Client: 200 OK (redis_available=false, redis_error=redis_queue_unavailable)
    end
    deactivate ApiServer

Loading

File-Level Changes

Change	Details	Files
Harden Redis health-check error handling to avoid exposing raw exception details in API responses while preserving diagnostics and logging.	Stop capturing the RedisError exception object for inclusion in the health response Add structured exception logging via logger.exception when Redis queue depth retrieval fails Mark Redis as unavailable on Redis errors and set a stable generic error token in the diagnostics payload instead of the raw exception text	backend/marketplace/router.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[parkcheolhong]

수정해줘

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider defining the "redis_queue_unavailable" token as a module-level constant (e.g., REDIS_QUEUE_UNAVAILABLE_ERROR) so it can be reused consistently and discovered more easily if other Redis error paths are sanitized in the future.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider defining the "redis_queue_unavailable" token as a module-level constant (e.g., REDIS_QUEUE_UNAVAILABLE_ERROR) so it can be reused consistently and discovered more easily if other Redis error paths are sanitized in the future.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Pull request overview

Mitigates code scanning alert #4 (“Information exposure through an exception”) by preventing raw Redis exception text from being returned in health diagnostics while preserving server-side observability via logging.

Changes:

• Replace redis_error = str(exc) with a stable, non-sensitive token ("redis_queue_unavailable") in get_ad_queue_runtime_status().
• Log the underlying RedisError server-side using logger.exception(...) for troubleshooting without exposing details to clients.