Harden orchestrator progress file paths and profiler bind host policy

[Copilot]

CodeQL reported multiple high-severity “uncontrolled data used in path expression” findings in backend/llm/orchestrator.py and a medium-severity “socket bound to all interfaces” finding in run_profiler_backend.py. This PR tightens both file-path derivation and network bind-host resolution to remove those unsafe flows.

• Path expression hardening (backend/llm/orchestrator.py)

  • Removed legacy run-id-derived path reuse logic.
  • Standardized progress file location to a fixed runtime root plus deterministic SHA-256 filename.
  • Limited path construction to trusted root + generated filename only, independent of user-controlled path segments.

• Profiler bind policy hardening (run_profiler_backend.py)

  • Default bind host is now loopback (127.0.0.1) regardless of container runtime.
  • Added explicit opt-in gate for remote binding via BACKEND_PROFILER_ALLOW_REMOTE=true.
  • Added stricter host validation:
    • localhost accepted only when it resolves to loopback addresses.
    • non-IP hostnames are rejected to loopback fallback.
    • all-interface binds (0.0.0.0 / ::) are only allowed behind explicit opt-in and logged.

def _orchestration_progress_file_path(run_id: str) -> Path:
    normalized_run_id = str(run_id if run_id is not None else "unknown")
    if normalized_run_id == "":
        normalized_run_id = "unknown"
    runtime_root = _runtime_progress_root().resolve()
    file_name = f"{hashlib.sha256(normalized_run_id.encode('utf-8')).hexdigest()}.json"
    return runtime_root / file_name

Summary by Sourcery

Harden progress file path derivation in the LLM orchestrator and tighten the profiler backend host binding policy to reduce security risk from untrusted input.

Bug Fixes:

• Ensure orchestration progress files are written under a fixed runtime root using a deterministic SHA-256-based filename independent of user-controlled path components.
• Constrain the profiler backend to bind to loopback by default with an explicit opt-in for remote access and validation of requested bind hosts.

Enhancements:

• Remove legacy run-id-based progress file path reuse logic in favor of the new deterministic scheme.
• Add logging and fallback behavior when profiler host resolution encounters unsafe or disallowed values such as non-loopback localhost, hostnames, or all-interface binds.

[parkcheolhong]

수정 감사합니다

[sourcery-ai]

Reviewer's Guide

Hardens orchestration progress file path derivation to remove legacy run-id-based paths and uses a deterministic SHA-256 filename under a fixed runtime root, and tightens the profiler backend’s bind-host resolution to default to loopback with explicit, validated opt-in for remote binding.

Sequence diagram for profiler backend host resolution and startup

sequenceDiagram
    actor Operator
    participant Env as Environment
    participant Main as main
    participant Resolver as _resolve_profiler_host
    participant Socket as socket
    participant IP as ipaddress
    participant Uvicorn as uvicorn

    Operator->>Main: invoke main()
    Main->>Env: read BACKEND_PROFILER_HOST
    Env-->>Main: BACKEND_PROFILER_HOST value or empty
    Main->>Env: read BACKEND_PROFILER_ALLOW_REMOTE
    Env-->>Main: BACKEND_PROFILER_ALLOW_REMOTE value or empty
    Main->>Resolver: _resolve_profiler_host()

    alt host is localhost
        Resolver->>Socket: getaddrinfo(localhost)
        Socket-->>Resolver: address infos
        alt all addresses are loopback
            Resolver-->>Main: host = localhost
        else any address is non loopback or resolution fails
            Resolver-->>Main: host = 127.0.0.1
        end
    else host is explicit loopback IP (127.0.0.1 or ::1)
        Resolver-->>Main: host = requested_host
    else host is other string
        Resolver->>IP: ip_address(requested_host)
        alt invalid IP string
            Resolver-->>Main: host = 127.0.0.1
        else valid IP
            alt IP is loopback
                Resolver-->>Main: host = requested_host
            else allow_remote is true
                Resolver-->>Main: host = requested_host
            else allow_remote is false
                Resolver-->>Main: host = 127.0.0.1
            end
        end
    end

    Main->>Main: _resolve_bind_port(host, requested_port)
    Main->>Uvicorn: run(app, host, port, reload=False)

Loading

File-Level Changes

Change	Details	Files
Harden orchestration progress file path derivation to avoid unsafe path usage.	Remove legacy progress file path helper and any logic that reused or migrated legacy run-id-based filenames. Normalize run_id to a non-empty string, falling back to 'unknown' for None or empty values. Resolve the runtime progress root once and construct the progress file path strictly as runtime_root plus a SHA-256 hash of the normalized run_id with a .json suffix, eliminating dependence on user-controlled path segments.	backend/llm/orchestrator.py
Restrict profiler backend bind host resolution to safe defaults with explicit opt-in for remote access.	Change the default profiler host to 127.0.0.1 regardless of container runtime. Introduce a _resolve_profiler_host helper that reads BACKEND_PROFILER_HOST and BACKEND_PROFILER_ALLOW_REMOTE, normalizes and validates the requested host, and enforces loopback-only binding unless remote access is explicitly allowed. Implement stricter host validation rules: accept localhost only if it resolves exclusively to loopback addresses; allow direct loopback IPs; reject non-IP hostnames to a 127.0.0.1 fallback; allow non-loopback and all-interface IPs only when BACKEND_PROFILER_ALLOW_REMOTE is enabled, with warnings for unsafe bindings. Update main() to use _resolve_profiler_host when determining the host passed to uvicorn.run, keeping existing port resolution and logging behavior.	run_profiler_backend.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[parkcheolhong]

고마워요~

[Copilot]

Pull request overview

Hardens two security-sensitive areas flagged by CodeQL: (1) orchestrator progress file path derivation to avoid user-influenced path expressions, and (2) profiler backend bind-host resolution to avoid unintended exposure by binding to all interfaces by default.

Changes:

• Standardizes orchestrator progress file storage to a fixed runtime root with a deterministic SHA-256 filename (removes legacy run-id-derived path reuse).
• Defaults the profiler backend bind host to loopback and adds an explicit BACKEND_PROFILER_ALLOW_REMOTE opt-in gate for non-loopback binding, with validation and warnings.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
run_profiler_backend.py	Adds host-resolution policy that defaults to loopback and gates remote/all-interface binds behind an explicit opt-in.
backend/llm/orchestrator.py	Reworks progress file path derivation to use a fixed trusted root plus SHA-256 filename.

[parkcheolhong]

@copilot apply changes based on this feedback

[parkcheolhong]

@copilot apply changes based on this feedback

[parkcheolhong]

@copilot apply changes based on the comments in this thread

[parkcheolhong]

수정해주세요~