Skip to content

refactor: upgrade linting dependencies#1946

Merged
mtrezza merged 30 commits intoparse-community:alphafrom
damianstasik:update-lint-deps
Oct 1, 2022
Merged

refactor: upgrade linting dependencies#1946
mtrezza merged 30 commits intoparse-community:alphafrom
damianstasik:update-lint-deps

Conversation

@damianstasik
Copy link
Copy Markdown
Contributor

@damianstasik damianstasik commented Dec 5, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

  • This PR replaces deprecated babel-eslint with @babel/eslint-parser and updates ESLint deps.
  • I ran the lint script and fixed simple issues, but there is one issue not related to this PR in src/dashboard/Data/Browser/Browser.react.js@464 which should be addressed in a separate issue.
  • I also removed experimentalObjectRestSpread and jsx flags from ESLint config as they are not needed, jsx: true is set by the React plugin and experimentalObjectRestSpread is no longer experimental.
  • root: true is needed, so that Babel ESLint parser knows how to locate the babel config...
  • ...which I extracted to a separate file so that both webpack and ESLint share the Babel same config
  • This PR also upgrades all Babel deps to avoid installing older version of @babel/eslint-parser that was compatible with older deps.

Related issue: #1902

Approach

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link
Copy Markdown

parse-github-assistant Bot commented Dec 5, 2021 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik damianstasik requested a review from mtrezza December 5, 2021 20:13
@damianstasik damianstasik mentioned this pull request Dec 5, 2021
Closed
56 tasks
mtrezza
mtrezza reviewed Dec 6, 2021
View reviewed changes
Comment thread src/dashboard/Data/Browser/Browser.react.js Outdated
mtrezza
mtrezza reviewed Dec 6, 2021
View reviewed changes
Comment thread src/dashboard/Data/Browser/DataBrowser.react.js
mtrezza
mtrezza reviewed Dec 6, 2021
View reviewed changes
Comment thread src/dashboard/Data/Browser/Browser.react.js Outdated
mtrezza
mtrezza reviewed Jan 29, 2022
View reviewed changes
Comment thread package.json Outdated
mtrezza
mtrezza reviewed May 29, 2022
View reviewed changes
Comment thread src/dashboard/Push/PushAudiencesIndex.react.js
@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented May 29, 2022 •
edited
Loading

Could you take a look at the failing test so can merge this?

mtrezza
mtrezza reviewed Sep 27, 2022
View reviewed changes
Comment thread ci/nodeEngineCheck.js Outdated
@damianstasik damianstasik requested a review from a team September 29, 2022 07:57
mtrezza
mtrezza requested changes Sep 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to resolve the conflict, tapable appears 2 times in the file.

mtrezza
mtrezza requested changes Sep 29, 2022
View reviewed changes
Comment thread ci/nodeEngineCheck.js Outdated
@damianstasik damianstasik mentioned this pull request Sep 30, 2022
Merged
@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented Oct 1, 2022 •
edited
Loading

Could you take a look at at the conflict? I tried to resolve it manually, but the CI started to fail, so I reverted.

@mtrezza
Revert "Merge branch 'alpha' into update-lint-deps"
36f3b2e 
This reverts commit d8e302e, reversing
changes made to 66234cb.
mtrezza
mtrezza approved these changes Oct 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title refactor: upgrade linting deps refactor: upgrade linting dependencies Oct 1, 2022
@mtrezza mtrezza merged commit 58f3d05 into parse-community:alpha Oct 1, 2022
@parseplatformorg
Copy link
Copy Markdown
Contributor

parseplatformorg commented Oct 9, 2022

🎉 This change has been released in version 5.0.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 9, 2022
@parseplatformorg
Copy link
Copy Markdown
Contributor

parseplatformorg commented Oct 17, 2022

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 17, 2022
@parseplatformorg
Copy link
Copy Markdown
Contributor

parseplatformorg commented Nov 1, 2022

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 1, 2022
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Dec 25, 2022
@cycqitianwushuge
Merge branch 'release'
0b9d770 
* release: (41 commits)
  chore(release): 5.0.0 [skip ci]
  ci: release commit
  chore(release): 5.0.0-beta.1 [skip ci]
  chore(release): 5.0.0-alpha.7 [skip ci]
  fix: using browser navigation backward / forward button clears data browser (parse-community#2317)
  docs: update changelog
  chore(release): 5.0.0-alpha.6 [skip ci]
  fix: raw value of read-only date field in data browser cannot be copied (parse-community#2326)
  chore(release): 5.0.0-alpha.5 [skip ci]
  feat: improve distinction between deletion confirmation dialogs (parse-community#2319)
  refactor: upgrade otpauth from 8.0.2 to 8.0.3 (parse-community#2322)
  refactor: upgrade graphiql from 2.0.7 to 2.0.8 (parse-community#2321)
  chore(release): 5.0.0-alpha.4 [skip ci]
  feat: keep entered filter value when changing filter operator (parse-community#2313)
  refactor: upgrade typescript from 4.8.2 to 4.8.3 (parse-community#2308)
  refactor: bump json-schema and jsprim (parse-community#2303)
  refactor: upgrade linting dependencies (parse-community#1946)
  refactor: upgrade semantic-release dependency (parse-community#2301)
  refactor: upgrade React Router to v6 (parse-community#1954)
  refactor: upgrade styling dependencies (parse-community#2300)
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@damianstasik @mtrezza @parseplatformorg @visualfanatic