Skip to content

refactor: upgrade React Router to v6#1954

Merged
mtrezza merged 27 commits intoparse-community:alphafrom
damianstasik:upgrade-to-react-router-v6
Oct 1, 2022
Merged

refactor: upgrade React Router to v6#1954
mtrezza merged 27 commits intoparse-community:alphafrom
damianstasik:upgrade-to-react-router-v6

Conversation

@damianstasik
Copy link
Copy Markdown
Contributor

@damianstasik damianstasik commented Dec 9, 2021

New Pull Request Checklist

Issue Description

Related issue: #1902

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link
Copy Markdown

parse-github-assistant Bot commented Dec 9, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented May 9, 2022

Damian, would you be available for a chat on Slack?

@damianstasik
Copy link
Copy Markdown
Contributor Author

damianstasik commented May 23, 2022 •
edited by mtrezza
Loading

@mtrezza yes, sure! You can reach me at <REMOVED>

@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented Sep 25, 2022 •
edited
Loading

@visualfanatic What is the state of this PR? Are you actively working on it?

@damianstasik
Copy link
Copy Markdown
Contributor Author

damianstasik commented Sep 25, 2022

@mtrezza I checked changes on alpha since my last update here and it looks like I don't have to adjust. Now I am going through each file making sure everything works as expected, and then I think it could be ready to be reviewed.

@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented Sep 25, 2022

Amazing, this will be a great merge!

@damianstasik
Copy link
Copy Markdown
Contributor Author

damianstasik commented Sep 25, 2022

@mtrezza what should we do about failing CI due to minimum Node version required by React Router 6?

@damianstasik damianstasik marked this pull request as ready for review September 25, 2022 15:53
@damianstasik
Copy link
Copy Markdown
Contributor Author

damianstasik commented Sep 25, 2022

@mtrezza I saw that there was an issue to remove Node 12 support, so I quickly did that to unblock this PR with updated router:
#2277

@damianstasik damianstasik mentioned this pull request Sep 26, 2022
Merged
5 tasks
@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented Sep 27, 2022 •
edited
Loading

@damianstasik Is his ready for review? If so, please request from dashboard-review team.

@damianstasik damianstasik requested a review from a team September 28, 2022 07:32
mtrezza
mtrezza requested changes Oct 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve the conflict?

@damianstasik damianstasik requested a review from mtrezza October 1, 2022 11:43
mtrezza
mtrezza approved these changes Oct 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and what an enormous PR! Waiting for CI...

@mtrezza mtrezza merged commit 650bcd5 into parse-community:alpha Oct 1, 2022
@parseplatformorg
Copy link
Copy Markdown
Contributor

parseplatformorg commented Oct 9, 2022

🎉 This change has been released in version 5.0.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 9, 2022
@parseplatformorg
Copy link
Copy Markdown
Contributor

parseplatformorg commented Oct 17, 2022

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 17, 2022
@parseplatformorg
Copy link
Copy Markdown
Contributor

parseplatformorg commented Nov 1, 2022

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 1, 2022
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Dec 25, 2022
@cycqitianwushuge
Merge branch 'release'
0b9d770 
* release: (41 commits)
  chore(release): 5.0.0 [skip ci]
  ci: release commit
  chore(release): 5.0.0-beta.1 [skip ci]
  chore(release): 5.0.0-alpha.7 [skip ci]
  fix: using browser navigation backward / forward button clears data browser (parse-community#2317)
  docs: update changelog
  chore(release): 5.0.0-alpha.6 [skip ci]
  fix: raw value of read-only date field in data browser cannot be copied (parse-community#2326)
  chore(release): 5.0.0-alpha.5 [skip ci]
  feat: improve distinction between deletion confirmation dialogs (parse-community#2319)
  refactor: upgrade otpauth from 8.0.2 to 8.0.3 (parse-community#2322)
  refactor: upgrade graphiql from 2.0.7 to 2.0.8 (parse-community#2321)
  chore(release): 5.0.0-alpha.4 [skip ci]
  feat: keep entered filter value when changing filter operator (parse-community#2313)
  refactor: upgrade typescript from 4.8.2 to 4.8.3 (parse-community#2308)
  refactor: bump json-schema and jsprim (parse-community#2303)
  refactor: upgrade linting dependencies (parse-community#1946)
  refactor: upgrade semantic-release dependency (parse-community#2301)
  refactor: upgrade React Router to v6 (parse-community#1954)
  refactor: upgrade styling dependencies (parse-community#2300)
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@damianstasik @mtrezza @parseplatformorg @visualfanatic