Skip to content

Fix/883 install edition dependencies #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmuenzenmeyer merged 4 commits into from
Jul 9, 2018
Merged

Fix/883 install edition dependencies #884

bmuenzenmeyer merged 4 commits into from
Jul 9, 2018

Conversation

@bmuenzenmeyer
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer commented Jul 9, 2018

Closes #883

Summary of changes:

  • Copy the edition's dependencies during init (node, gulp)
  • Namespace edition-node scripts to avoid collisions

@bmuenzenmeyer
Merge pull request #881 from pattern-lab/dev
e9b1df9 
Next version
@bmuenzenmeyer
Publish
8be2cc5 
 - @pattern-lab/cli@0.0.1-alpha.22
 - @pattern-lab/core@3.0.0-alpha.16
 - @pattern-lab/engine-react-testing-tree@0.1.1-alpha.4
 - @pattern-lab/edition-node@1.0.0-alpha.12
 - @pattern-lab/edition-node-gulp@2.0.0-alpha.14
 - @pattern-lab/live-server@1.3.3-alpha.6
@bmuenzenmeyer
fix(install): copy dependencies
1acef87 
wip
@bmuenzenmeyer
feat(scripts): namespace scripts
3ecbb3e
@coveralls
Copy link

coveralls commented Jul 9, 2018

Coverage Status

Coverage remained the same at 73.39% when pulling 3ecbb3e on fix/883-install-edition-dependencies into c40f4d9 on dev.

@bmuenzenmeyer bmuenzenmeyer merged commit 7232cd4 into dev Jul 9, 2018
@bmuenzenmeyer bmuenzenmeyer deleted the fix/883-install-edition-dependencies branch July 9, 2018 14:19
@raphaelokon raphaelokon self-requested a review July 9, 2018 18:31
raphaelokon
raphaelokon reviewed Jul 9, 2018
View reviewed changes
Copy link
Contributor

@raphaelokon raphaelokon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
@bmuenzenmeyer
Merge pull request pattern-lab#884 from pattern-lab/fix/883-install-e…
fa413b3 
…dition-dependencies

Fix/883 install edition dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raphaelokon raphaelokon raphaelokon left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bmuenzenmeyer @coveralls @raphaelokon