Skip to content

Plugin work #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmuenzenmeyer merged 20 commits into from
Jul 27, 2018
Merged

Plugin work #898

bmuenzenmeyer merged 20 commits into from
Jul 27, 2018

Conversation

@bmuenzenmeyer
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer commented Jul 17, 2018

closes #873
closes #872
closes #894

Summary of changes:

  • Fixes patternlab-config.json resolution within the CLI
  • Officially relies on the CLI for all plugin installation / enabling / disabling, deleting duplicate code from core
  • Standardizes all JSON writes within the CLI to preserve whitespace

bmuenzenmeyer and others added 16 commits July 3, 2018 06:22
@bmuenzenmeyer
feat(package): revamp plugin-tab
2aa0f8f 
support for uikits
support scoped package
@bmuenzenmeyer
fix(cli): support scoped plugins
4ae13ce
@bmuenzenmeyer
fix(docs): update event info with tab example
0f227a3
@bmuenzenmeyer
feat(API): remove reliance on patternlab object during plugin install
0850fd6
@bmuenzenmeyer
chore(core): WIP initialize plugins
197fc35
@bmuenzenmeyer
fix(plugins): support scoped packages
44f0f8e
@bmuenzenmeyer
chore(core): WIP initialize plugins
066e6c9
@bmuenzenmeyer
Merge branch 'dev' into plugin-work
0071a85
@bmuenzenmeyer
chore(package): code cleanup
5293975
@bmuenzenmeyer
fix(package): fix pathing and naming issues
45583f8
@bmuenzenmeyer
chore(package): cleanup
bc2a0d3
@raphaelokon
Make default config directory agnostic. Fix kepabCasing beaking installs
29f0bb4
@bmuenzenmeyer
feat(core): remove plugin install / disable / enable logic
5a58824 
moves initialize logic into plugin_manager
closes #872
@bmuenzenmeyer
chore(cli): remove kebabbing of plugin name
0abfb7b
@bmuenzenmeyer
refactor(cli): always use same options when writing JSON
3a6582c
@bmuenzenmeyer
fix(cli): set initialized to false during plugin installation
88cce3f
@bmuenzenmeyer bmuenzenmeyer self-assigned this Jul 17, 2018
@coveralls
Copy link

coveralls commented Jul 17, 2018

Coverage Status

Coverage increased (+1.2%) to 74.583% when pulling a1a9779 on plugin-work into 2b70ff4 on dev.

@bmuenzenmeyer bmuenzenmeyer merged commit 07f38ef into dev Jul 27, 2018
@bmuenzenmeyer bmuenzenmeyer deleted the plugin-work branch July 27, 2018 16:18
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
@bmuenzenmeyer
Merge pull request pattern-lab#898 from pattern-lab/plugin-work
2ec61ce 
Plugin work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bmuenzenmeyer bmuenzenmeyer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cli] init-created patternlab-config.json files need new line [cli] plugin installation not working [core] Remove plugin installation code

4 participants

@bmuenzenmeyer @coveralls @raphaelokon