Workaround / Fix for Top-level Viewall + Markdown Issue

[sghoweri]

Workaround / possible fix to address PL Node viewall page issues when compiling standalone markdown files in top-level pattern folders. This update tweaks how injectDocumentationBlock handles existing "pre-processed" documentation data (ie. markdown files) by processing all patterns the same way (new Pattern.createEmpty) but still include the pattern description data if it already exists.

Addresses #890 and #970.

[sghoweri]

@bmuenzenmeyer -- heads up, looks like this bug might be much more complex than I thought.

While it looks like this particular update helps with a pattern folder a few levels deep, it looks like things still get wonky if there's heavily nested patterns =/

Works

Broken

Without doing quite a bit more reverse engineering (or refactoring), I'm not sure how much further I can take this myself -- any ideas on where I should be digging around?

[bmuenzenmeyer]

@sghoweri will take a look!

[sghoweri]

@bradfrost what should we do here? Merge this potential fix in? Hold off?

[bradfrost]

@sghoweri hmmm I unfortunately don't think I can speak to this regarding what to do with it, this one seems more @bmuenzenmeyer's department.

[bmuenzenmeyer]

@sghoweri lemme see if i can recover where I was with this

[stale]

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

[stale]

Issue closed after going stale. It can be re-opened if still relevant.

[stale]

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

[stale]

Issue closed after going stale. It can be re-opened if still relevant.

[bmuenzenmeyer]

I want to use https://patternlab-handlebars-preview.netlify.com/ to re-assess if this is still a problem

[bmuenzenmeyer]

@sghoweri with our recent conversation revealing that top-level pattern type (atoms, molecules) documentation was never implemented, I would rather we look at it holisitically rather than patch

please reopen if you disagree