Skip to content

Conversation

@bennypowers
Copy link
Member

Allows downstream to use markdown-it plugins to manipulate output e.g. by adding hash links to headers

Unblocks RedHat-UX/red-hat-design-system#1051

What I did

  1. in DocsPage templates, print headings as markdown instead of as HTML

Testing Instructions

  1. compare DP to https://patternflyelements.org/, https://patternflyelements.org/get-started/, and https://patternflyelements.org/components/avatar/

Allows downstream to use markdown-it plugins to manipulate output
e.g. by adding hash links to headers
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

⚠️ No Changeset found

Latest commit: 498bad1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added tools Development and build tools AT passed Automated testing has passed labels Jun 13, 2023
@heyMP heyMP added work in progress POC / Not ready for review and removed work in progress POC / Not ready for review labels Jun 14, 2023
@heyMP
Copy link
Contributor

heyMP commented Jun 14, 2023

Deploy Preview isn't working. Looks like there is an error associated with floating-ui.

@bennypowers
Copy link
Member Author

The error hasto do jspm's cdn provider cc @guybedford

@github-actions
Copy link
Contributor

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit d02d534
😎 Deploy Preview https://deploy-preview-2516--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers bennypowers enabled auto-merge (squash) June 15, 2023 14:15
@bennypowers bennypowers merged commit 3acb41b into main Jun 15, 2023
@bennypowers bennypowers deleted the tools/docspage-md-headings branch June 15, 2023 14:32
@bennypowers bennypowers mentioned this pull request Jun 16, 2023
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed ready to merge tools Development and build tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants