US198282: Updated accordion styles #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrisdo1
commented
Mar 13, 2019
chrisdo1
commented
- set mixins for accordion header
- reset placement for chevrons
- styled nested accordions
* linked to extends in accordion scss file * set extends naming to expand button
chrisdo1
changed the title
Set accordion placeholders fork
* removed borders on top of accordion headers * fixed border-left color on dark expanded accordions * cleaned up sass vars in mixins.scss
* fixed accordion header and panel when on=dark and no color attribute is applied.
* fixed accordion styles when on=dark and no color attributes are applied.
* commented out color attribute settings
* made chevrons narrower and slightly larger
…to use default text & link + on-dark text & link colors, add hover state, update color of focus state
Member
|
This looks great!! Thank you @chrisdo1! 🎉 |
starryeyez024
added
the
ready: browser testing
Contributor
Author
@starryeyez024 Thanks for the review, Kendall. There was an additional commit that I made this morning to address a bug that Cassondra found on Edge 18. @castastrophe I have fixed that container bug and pushed up the changes to the sshell sandbox. I think that the band issue might have happened because I didn't link the pfe-band when I rebuilt the webrh.webcomponents.js file. |
…rnfly/patternfly-elements into set-accordion-placeholders
… broadcasted variable for ui-links in theme mixin
Suggested mixin updates
castastrophe
approved these changes
Mar 22, 2019
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
Looks awesome! Love the design work here. Really phenomenal.
starryeyez024
removed
ready: browser testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.