pfe-card -- fix storybook issue with incorrect attribute #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castastrophe
suggested changes
Oct 18, 2019
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
Duplicative return statement - provided proposed update
Co-Authored-By: [ Cassondra ] <castastrophe@users.noreply.github.com>
Member
Author
|
@castastrophe I updated this branch w/ your suggestions (thanks!) & the latest from master. Ready to merge? |
Contributor
|
@starryeyez024 Needs a changelog |
castastrophe
approved these changes
Oct 21, 2019
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
👍 Lions growl through mountains
castastrophe
added
ready to merge
and removed
needs code updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed and why
In Storybook, the incorrect attribute of color is shown, instead of pfe-color
https://patternfly.github.io/patternfly-elements/demo/
Testing instructions
Be sure to include detailed instructions on how your update can be tested by another developer.
npm run storybookpfe-coloris shownReady-for-merge Checklist
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!