Skip to content

pfe-card -- fix storybook issue with incorrect attribute #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starryeyez024 merged 6 commits into from
Oct 21, 2019
Merged

pfe-card -- fix storybook issue with incorrect attribute #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3d3e6cc
add prefix to schema, update JS
starryeyez024 Oct 17, 2019
17c69d8
fix background color function so it does not eval T/F
starryeyez024 Oct 17, 2019
bc7a3ca
Merge branch 'master' into pfe-card-schema-storybook
starryeyez024 Oct 18, 2019
484058e
Update elements/pfe-card/src/pfe-card.js
starryeyez024 Oct 21, 2019
f3d3299
Merge branch 'master' into pfe-card-schema-storybook
starryeyez024 Oct 21, 2019
eff8602
[dev]: Update changelog
Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG-prerelease.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ Tag: [v1.0.0-prerelease.26](https://github.com/patternfly/patternfly-elements/re
- [6b5db77](https://github.com/patternfly/patternfly-elements/commit/6b5db77c20358499f78b66811b73ea6be309318b) Update documentation
- [d4600dd](https://github.com/patternfly/patternfly-elements/commit/d4600dd1c6e2abfcf8918d06b4eaacb8fb62d208) Add automatic Sass globbing to pfe-sass
- [27a97e1](https://github.com/patternfly/patternfly-elements/commit/27a97e135986de37ede55504a1630bf974de0e0c) pfe-cta: fix functions & IE11 accessibility
- []() Upgrade to latest version of storybook #366
- [9a39ae3](https://github.com/patternfly/patternfly-elements/commit/9a39ae3b7d0b8d129a3aea3b58e71dab5013c721) fix: Adding object-fit to resolve image distortion in cards, #417
- [980203b](https://github.com/patternfly/patternfly-elements/commit/980203b2768d1d9d8813f386bb0f0bf37d3732ab) feat: Upgrade to latest version of storybook (#366)
- [ab5bc0e](https://github.com/patternfly/patternfly-elements/commit/ab5bc0e66b1e0f2f4ba180ff80d24b84d0db3260) feat: added sm md and xl sizes for pfe-progress-indicator (#575)
- [fc51ba](https://github.com/patternfly/patternfly-elements/commit/fc51baf1cb4313ca117cc505ba9c0e99dd44d0e9) feat: Add pfe-number schema (#576)
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: pfe-card: storybook issue with incorrect attribute (#573)

## Prerelease 25 ( 2019-09-10 )

Expand Down
4 changes: 1 addition & 3 deletions elements/pfe-card/src/pfe-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,7 @@ class PfeCard extends PFElement {
}

get backgroundColor() {
return (
this.getAttribute("pfe-color") || this.getAttribute("color") || "base"
);
return this.getAttribute("pfe-color") || "base";
}

static get observedAttributes() {
Expand Down
1 change: 1 addition & 0 deletions elements/pfe-card/src/pfe-card.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"accent"
],
"default": "base",
"prefixed": true,
"observer": "_colorChanged"
},
"img-src": {
Expand Down