-
Notifications
You must be signed in to change notification settings - Fork 377
Closed
Labels
Milestone
Description
The page demos are missing vertical navigation - https://www.patternfly.org/v4/components/page/react-demos
It's not necessary for the demo, but I think all of the fullpage demos should have a complete basic page structure.
Also I noticed that the sticky group demos (https://www.patternfly.org/v4/components/page/react-demos/sticky-section-group/ and https://www.patternfly.org/v4/components/page/react-demos/sticky-section-group-using-pageheader/)...
- one has the sidebar/nav expanded, and the other doesn't (and the hamburger menu doesn't seem to work)
- require you shrink the window size down quite a bit to see the sticky behavior (to trigger overflow/scrollbar) - especially when the sidebar/nav is collapsed.
- In core, we have 2 variations of the page demo main section with a gallery of cards - a basic, shorter gallery of cards, and a longer gallery for when we want to show overflow behavior in the main section, so you don't have to resize the browser much or at all.
Some/all of this may be resolved via #7526, which updates the page demos to use the <DashboardWrapper /> component. If so feel free to edit or close this if that's preferred.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done