fix(utils): export common utility functions and constants in react-core #1232
Conversation
|
PatternFly-React preview: https://1232-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4316
💛 - Coveralls |
| @@ -1,4 +1,5 @@ | |||
| export * from './components'; | |||
| export * from './layouts'; | |||
| export * from './internal'; | |||
There was a problem hiding this comment.
kind of semantics, but if it is exported it is not really internals anymore. Maybe rename to helpers or something similar?
There was a problem hiding this comment.
i was thinking the same thing this morning actually... i'm up for this if others are.
There was a problem hiding this comment.
ok, works for me. Will update soon.
|
@priley86 looks like this one still needs some updates and conflicts resolved. |
|
will rebase this and update to |
priley86
force-pushed
the
export-utils
branch
from
f47997a to
fcdfdbb
Compare
|
*rebased and tested locally. Should be g2g. |
| export function debounce(func, wait) { | ||
| let timeout; | ||
| return (...args) => { | ||
| export function debounce(this: any, func: (...args: any[]) => any, wait: number) { |
There was a problem hiding this comment.
Method signature has changed, is it needed to use this as first argument?
…re (patternfly#1232) * fix(utils): export common utility functions and constants used in react-core * renamed internal to helpers * update debounce method
8 participants
What:
A minor minor addition to react-core to help out #1227
Additional issues:
none