Updated to core 178 and refactor from patternfly-next to patternfly. #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabaj
requested review from
dgutride,
ibolton336,
jschuler,
kmcfaul,
rebeccaalpert and
tlabaj
dgutride
suggested changes
Feb 4, 2019
Member
dgutride
left a comment
dgutride
left a comment
There was a problem hiding this comment.
Looks good - three minor fixes
karelhala
reviewed
Feb 4, 2019
packages/patternfly-4/react-table/src/components/Table/ExpandableRowContent.js
Outdated
Show resolved
Hide resolved
Collaborator
|
PatternFly-React preview: https://1317-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4284
💛 - Coveralls |
dgutride
approved these changes
Feb 4, 2019
dgutride
pushed a commit
to dgutride/patternfly-react
that referenced
this pull request
Feb 6, 2019
…atternfly#1317) * Updated to core 178 * Updated snapshots. * Updated with code review comments. * Updates from rebase with table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Refactor from patternfly-next to patternfly to align with beta. Updated to the latest build of core 178.
Additional issues:
None