Skip to content

fix(nvmrc): remove nvmrc checks and reenable node6 support #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeff-phillips-18 merged 1 commit into from
Dec 20, 2017
Merged

fix(nvmrc): remove nvmrc checks and reenable node6 support #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{
"rules": {
"prettier/prettier": ["error", { "singleQuote": true, "trailingComma": "all" }]
"prettier/prettier": [
"error",
{ "singleQuote": true, "trailingComma": "none" }
]
},
"extends": [
"standard",
Expand All @@ -19,9 +22,6 @@
"jsx": true,
"experimentalObjectRestSpread": true
},
"plugins": [
"prettier",
"react"
],
"plugins": ["prettier", "react"],
"parser": "babel-eslint"
}
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ notifications:
email: false
node_js:
- '8'
- '6'
before_script:
- npm prune
script:
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ As an alernative to consuming the `patternfly-react.css` file (found in `dist/cs

## Node Environment

To build you **must** use Node 8. If you are not using Node 8, you will get an error at `npm install` time. Please install and use via:
This project currently supports Node [Active LTS](https://github.com/nodejs/Release#release-schedule) releases. Please stay current with Node Active LTS when developing patternfly-react.

For example, to develop with Node 8, use the following:
```
nvm install 8
nvm use 8
```

Run `npm install` again. If you then get an error with `Node Sass`, remove the `node_modules` and `npm install` again (to pull the correct version of node-sass).

## Storybook UI Development
This project uses [React Storybook](https://getstorybook.io/) to test and demo new React UI components. You can view our current storybook [here](https://rawgit.com/patternfly/patternfly-react/gh-pages/index.html).

Expand Down
Loading