fix(nvmrc): remove nvmrc checks and reenable node6 support

[priley86]

What:
Closes #136 and removes nvmrc-check

cc: @jeff-phillips-18 @sharvit

[sharvit]

https://github.com/parshap/check-node-version

[priley86]

so we need Node 8 while developing in this project, but I don't think we want to specify that downstream (you could be using Node6/Node5/Node4) for example there. So I don't think a postinstall check fits the bill...

suggestions on this?

[jeff-phillips-18]

I'm fine with removing the postinstall check. We likely want to remove the extra commas from :

https://github.com/patternfly/patternfly-react/blob/master/storybook/webpack.config.js#L29 https://github.com/patternfly/patternfly-react/blob/master/storybook/webpack.config.js#L33

and add the file to eslint ignore. Or, better yet, remove the eslint requirement to have trailing commas.

[priley86]

yep... Node6 seems to break when running npm run storybook currently... 👍

Update the PR to just change that setting globally and build node 6, as I'd prefer not to add ignores and get myself confused 😸

[cdcabrera]

Agreeable on the update, postinstall always seems to come back around, happened on some of the other PF repos with Jekyll, same outcome removing the script.

If the trailing comma stuff pops back up as someone wanting to implement it under the guise of "it affects diffs" an alternative is the leading comma (not a fan of this style).