docs(addon-info): lock addon-info to 3.2.12#147
Merged
jeff-phillips-18 merged 1 commit intopatternfly:masterfrom Jan 4, 2018
Merged
docs(addon-info): lock addon-info to 3.2.12#147jeff-phillips-18 merged 1 commit intopatternfly:masterfrom
jeff-phillips-18 merged 1 commit intopatternfly:masterfrom
Conversation
Member
Author
jeff-phillips-18
previously approved these changes
Jan 2, 2018
Member
|
storybook 3.3 is released - did you check if the issue is solved? (
https://medium.com/storybookjs/announcing-storybook-3-3-9972c4bc87ac)
…On Tue, Jan 2, 2018 at 1:59 PM, Jeffrey Phillips ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#147 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOx0A_tfvx4jrcikh6zdiMQ7svYvJLks5tGhougaJpZM4RP3ho>
.
|
Member
Author
|
@ohadlevy i too am very excited about the 3.3 features, have been following those ;) I think the main problem is the second issue I noted about propTypes and imported constants. It looks like the way we are currently structured is not supported by addon-info/react-docgen. Hopefully they get a fix soon. I just +1'd this issue which has a workaround if we want to use it cc: @sharvit... the first issue (around .env) warnings can be resolved by simply creating a new empty |
priley86
force-pushed
the
fix-storybook
branch
from
731cc84 to
1e929bd
Compare
jeff-phillips-18
approved these changes
Jan 4, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lock addon-info to 3.2.12 to temporarily address 3.2.18 issues
What:
There is currently a bug when resizing the addon panel:
This appears to be due to some conflicts with
3.2.18and some of the newer3.3packages now being pulled in semantically.I first attempted to update all
@storybookpackages to3.3.3, however it seems there a few issues which need to be resolved first. I commented on those here and here.Locking addon-info temporarily seems to resolve the resize issue noted in the giphy above and avoids the new 3.3.3 issues presented upstream.
Once 3.3.3 issues are resolved, we should be able to update all
@storybookpackages along with removing our currently deprecated usage of the addon-info component.Link to Storybook:
Working storybook built by these updates is here:
https://rawgit.com/priley86/patternfly-react/fix-storybook-sb/index.html
Additional issues:
nope