Set title in storybook and prepare for hierarchy#186
Merged
priley86 merged 1 commit intopatternfly:masterfrom Feb 1, 2018
aljesusg:improve_storybook
Merged
Set title in storybook and prepare for hierarchy#186priley86 merged 1 commit intopatternfly:masterfrom aljesusg:improve_storybook
priley86 merged 1 commit intopatternfly:masterfrom
aljesusg:improve_storybook
Conversation
Collaborator
|
Looks good @aljesusg. I didn't know you could define a hierarchy in storybook like that. |
jeff-phillips-18
approved these changes
Jan 24, 2018
Member
|
should be fine... it's the |
priley86
approved these changes
Jan 24, 2018
Member
|
@aljesusg it looks like we missed the package-lock entries... We have removed package-lock in our downstream product, but I personally still think it makes sense to lock packages shared in this repo (for compatibility reasons it seems safer). WDYT? Would you mind submitted a PR to update package lock? Simply pull latest and NPM install... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can see patternfly-react instead of storybook.
But the point of add this options is to add hierarchy tree in next PRs
This will provide us to have a category :
only with