Skip to content

Set title in storybook and prepare for hierarchy#186

Merged
priley86 merged 1 commit intopatternfly:masterfrom
aljesusg:improve_storybook
Feb 1, 2018
Merged

Set title in storybook and prepare for hierarchy#186
priley86 merged 1 commit intopatternfly:masterfrom
aljesusg:improve_storybook

Conversation

@aljesusg
Copy link
Contributor

@aljesusg aljesusg commented Jan 24, 2018

captura de pantalla 2018-01-24 a las 13 47 20
Now you can see patternfly-react instead of storybook.

But the point of add this options is to add hierarchy tree in next PRs

/**
   * regex for finding the hierarchy separator
   * @example:
   *   null - turn off hierarchy
   *   /\// - split by `/`
   *   /\./ - split by `.`
   *   /\/|\./ - split by `/` or `.`
   * @type {Regex}
   */
  hierarchySeparator: null,
  /**
   * regex for finding the hierarchy root separator
   * @example:
   *   null - turn off mulitple hierarchy roots
   *   /\|/ - split by `|`
   * @type {Regex}
   */
  hierarchyRootSeparator: null

This will provide us to have a category :

  • navigation
    • vertical
      • types
    • horizontal
      • types
        only with
storiesOf('navigation/vertical/type/')
  .add('storyName', () => <MyComponent />);

captura de pantalla 2018-01-24 a las 13 47 20

@mturley
Copy link
Collaborator

mturley commented Jan 24, 2018

Looks good @aljesusg. I didn't know you could define a hierarchy in storybook like that.

@priley86
Copy link
Member

priley86 commented Jan 24, 2018

should be fine... it's the @storybook/addon-info package that breaks when upgrading to 3.3. I noted a possible fix for this in #147 if anyone wants to take a stab at fixing it. Let's just keep an eye out for this...

@priley86 priley86 merged commit 1ce73ad into patternfly:master Feb 1, 2018
@jgiardino jgiardino removed the review label Feb 1, 2018
@priley86
Copy link
Member

priley86 commented Feb 2, 2018

@aljesusg it looks like we missed the package-lock entries... We have removed package-lock in our downstream product, but I personally still think it makes sense to lock packages shared in this repo (for compatibility reasons it seems safer). WDYT?

Would you mind submitted a PR to update package lock? Simply pull latest and NPM install...

    "@storybook/addon-options": {
      "version": "3.3.11",
      "resolved": "https://registry.npmjs.org/@storybook/addon-options/-/addon-options-3.3.11.tgz",
      "integrity": "sha512-RjXwNegDojYmhGNXDshb24HGpSQO8ZHVvHf/xytCuzNBkH48tlczDA6HfbbgUQKWMlsYEqh8EA4dPba1z8iXUg==",
      "dev": true
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants