feat(About): add ability to use product title image#198
feat(About): add ability to use product title image#198cdcabrera merged 1 commit intopatternfly:masterfrom
Conversation
serenamarie125
left a comment
There was a problem hiding this comment.
@jeff-phillips-18 this looks good. Now there is a choice to either use text or an SVG right?
| /** Text to show for the product title */ | ||
| productTitle: PropTypes.string, | ||
| /** Text or Element to show for the product title */ | ||
| productTitle: PropTypes.oneOfType([PropTypes.string, PropTypes.node]), |
There was a problem hiding this comment.
I think it can be as simple as:
productTitle: PropTypes.node,Since node can be a string.
There was a problem hiding this comment.
Thanks. Updated.
fdf047b to
45acc9b
Compare
|
+1... for |
|
validated in my semantic-release playground that |
|
For the most part we tend to keep our use of semantic release types limited. Going to go ahead and look like I'm flip-flopping, and merge this in. There is a bit of subjective to these, and this is one of those in-between updates that's kind of enhancing the existing component and not breaking previous behavior. Where fix seems like an odd choice, since the component isn't actually broken. For future reference, based on the Commitizen types, per @priley86 |
What:
Adds the ability to pass an image (or other node) for the product title in the about modal.
Link to Storybook:
https://jeff-phillips-18.github.io/patternfly-react/
Additional issues:
Fixes #197