Skip to content

feat(About): add ability to use product title image #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdcabrera merged 1 commit into from
Jan 31, 2018
Merged

feat(About): add ability to use product title image #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/AboutModal/AboutModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ AboutModal.propTypes = {
show: PropTypes.bool.isRequired,
/** Function to call when modal is closed */
onHide: PropTypes.func.isRequired,
/** Text to show for the product title */
productTitle: PropTypes.string,
/** Text or Element to show for the product title */
productTitle: PropTypes.node,
/** Image Source for the Product logo */
logo: PropTypes.string,
/** Alternate text if invalid logo */
Expand Down
3 changes: 2 additions & 1 deletion src/components/AboutModal/__mocks__/mockAboutModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from 'react';
import { Button } from '../../Button';
import { AboutModal } from '../index';
import logo from 'patternfly/dist/img/logo-alt.svg';
import productTitle from 'patternfly/dist/img/brand-alt.svg';

export class MockAboutModal extends React.Component {
constructor() {
Expand All @@ -26,7 +27,7 @@ export class MockAboutModal extends React.Component {
<AboutModal
show={this.state.showModal}
onHide={this.close}
productTitle="Product Title"
productTitle={<img src={productTitle} alt="Product Title" />}
logo={logo}
altLogo="Patternfly Logo"
trademarkText="Trademark and Copyright Information"
Expand Down