Skip to content

Conversation

@dlabrecq
Copy link
Member

@dlabrecq dlabrecq commented Feb 7, 2022

  • Updated react and react-dom package dependencies to 18.0.0-rc.0.
  • Replace ReactDOM.render with ReactDOM.createRoot

The tests fail because there is no Enzyme adapter for React 18. May need to move to the React Testing Library?

See https://dev.to/wojtekmaj/enzyme-is-dead-now-what-ekl

@patternfly-build
Copy link
Collaborator

patternfly-build commented Feb 7, 2022

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore comment. wrong PR

@dlabrecq dlabrecq changed the title chore(react): Update react and react-dom package dependencies to rc.0 chore(react): Update react and react-dom pkg dependencies to 18.0.0-rc.0 Feb 8, 2022
@dlabrecq dlabrecq force-pushed the react-dependencies branch 3 times, most recently from 61d8ef8 to a36b210 Compare February 9, 2022 19:21
@tlabaj tlabaj mentioned this pull request Mar 29, 2022
20 tasks
@jonkoops
Copy link
Contributor

@dlabrecq I have opened up a similar PR that uses the final version of React 18 and includes some other enhancements here #7146. Perhaps we can collaborate on that branch together?

@jonkoops
Copy link
Contributor

@tlabaj considering the lack of response and the ongoing work for React 18 support it might be a good idea to close this PR.

@dlabrecq dlabrecq closed this May 9, 2022
@dlabrecq dlabrecq deleted the react-dependencies branch May 9, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants