Add support for version 18 of React #7146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
commented
Mar 29, 2022
jonkoops
commented
Mar 29, 2022
Collaborator
|
Preview: https://patternfly-react-pr-7146.surge.sh A11y report: https://patternfly-react-pr-7146-a11y.surge.sh |
This was referenced Mar 30, 2022
jonkoops
force-pushed
the
react-18
branch
3 times, most recently
from
d55d83d to
3d3d551
Compare
jonkoops
force-pushed
the
react-18
branch
4 times, most recently
from
15f0136 to
5fe4e5b
Compare
jonkoops
force-pushed
the
react-18
branch
2 times, most recently
from
1afa0c6 to
8beae43
Compare
jonkoops
force-pushed
the
react-18
branch
2 times, most recently
from
3060d53 to
818127b
Compare
jonkoops
force-pushed
the
react-18
branch
5 times, most recently
from
2bff7d2 to
657e6bb
Compare
jonkoops
force-pushed
the
react-18
branch
3 times, most recently
from
6ea938d to
148cf67
Compare
jonkoops
force-pushed
the
react-18
branch
2 times, most recently
from
6a121e4 to
82457cc
Compare
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Everything here looks good to me, I'm ready to approve once you resolve the merge conflicts!
Contributor
Author
|
Sorry for the delay, I was on vacation so I had no time to look at this. @wise-king-sullyman I've rebased the PR. |
Collaborator
|
@jonkoops it looks like there are unit tests failing now, based on some quick research though I think those failures should be resolved if you bump our React Testing Library version. |
Contributor
Author
|
@wise-king-sullyman did another rebase and updated the version of React Testing Library. All is looking green now ✔️ |
wise-king-sullyman
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards closing #7142