chore(Table): update sticky header table data #7851
Conversation
|
Preview: https://patternfly-react-pr-7851.surge.sh A11y report: https://patternfly-react-pr-7851-a11y.surge.sh |
There was a problem hiding this comment.
This is looking good @jenny-s51 . Just a couple of small asks...
- Is it possible to give the URL text in the last column link styling?
- As I mentioned on another PR, if the status column could display these as labels vs text, that would be preferrable, but not a necessity.
Here's a mockup of what this ideally would look like: https://marvelapp.com/prototype/2ff7ahj6/screen/87992956
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Since all these PRs us the same data, they would all have the same comments about its formatting as I mentioned in this comment:
#7857 (comment)
#7857 (comment)
#7857 (comment)
jenny-s51
force-pushed
the
stickyHeaderTableData
branch
from
05d2d92 to
7fc240a
Compare
jenny-s51
force-pushed
the
stickyHeaderTableData
branch
from
7fc240a to
509c9fe
Compare
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Is it possible to use the dashboard wrapper in this demo?
if not, should we opt for the Masthead rather than the PageHeader?
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Nice catch @nicolethoen ! Updated to use the DashboardWrapper.
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Could you also clean up the unused imports?
|
@jenny-s51 this looks much better, but just one question- What controls the column widths? It seems odd that the first 3 columns get so much space and then the columns at the end are very tight forcing 'Last modified' and 'URL' to wrap. |
|
@mcarrano I added some modifiers to the column widths as suggested by @nicolethoen here: #7857 (review) This was to prevent the "Workspaces" and "Applications" columns from truncating like this (which is what the table would look like without the column width modifiers): WDYT @mcarrano ? Should we use these modifiers? Happy to update as you see fit. |
Could we truncate the urls? so they take up less space and also don't wrap? |
Yes, I think that makes sense. |
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Added the truncate modifier and added fixed widths @mcarrano @nicolethoen:
|
Could we make the location column just a bit wider so those values don't need to wrap? |
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
Looks great. Thanks for making these changes @jenny-s51 !
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
5 participants
What: Closes #7358 , towards #7384
Demo link for convenience: https://patternfly-react-pr-7851.surge.sh/components/table/react-demos/sticky-header/