chore(table): update compact table data #7857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-s51
force-pushed
the
compactTableData
branch
2 times, most recently
from
00173ec to
108e5c9
Compare
Collaborator
|
Preview: https://patternfly-react-pr-7857.surge.sh A11y report: https://patternfly-react-pr-7857-a11y.surge.sh |
nicolethoen
requested changes
Aug 18, 2022
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Since the URL cell is so long, i wonder if that should have a fixed width so the urls get truncated rather than the shorter Applications and Workspace titles.
jenny-s51
force-pushed
the
compactTableData
branch
2 times, most recently
from
8bf79da to
bf24c62
Compare
jenny-s51
changed the title
jenny-s51
force-pushed
the
compactTableData
branch
from
92affae to
111b708
Compare
jenny-s51
changed the title
nicolethoen
approved these changes
Sep 1, 2022
mcarrano
approved these changes
Sep 1, 2022
Member
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
This looks great. Thanks @jenny-s51 !
jenny-s51
force-pushed
the
compactTableData
branch
from
129eb88 to
953a64d
Compare
jenny-s51
force-pushed
the
compactTableData
branch
from
953a64d to
b6acc91
Compare
tlabaj
approved these changes
Sep 7, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
andyyvo
pushed a commit
to andyyvo/patternfly-react
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7855
Additional issues: Towards #7384
Convenience link to demo: https://patternfly-react-pr-7857.surge.sh/components/table/react-demos/compact/