feat(resizeObserver): allow opting out of using requestAnimationFrame #7941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-7941.surge.sh A11y report: https://patternfly-react-pr-7941-a11y.surge.sh |
dlabrecq
reviewed
Sep 6, 2022
Comment on lines
+91
to
+93
| * public componentDidMount() { | ||
| * this.observer = getResizeObserver(this.inputRef.current, debounce(this.handleResize, 250), false); | ||
| * } |
Member
There was a problem hiding this comment.
Thinking we can simplify the examples?
There are currently 4 full examples, but the only change seems to be in componentDidMount, so perhaps we can just show how that method? For example, something more like this might be enough:
Example 3 - With debounced method passed in
public componentDidMount() {
this.observer = getResizeObserver(this.inputRef.current, debounce(this.handleResize, 250), false);
}
jschuler
approved these changes
Sep 6, 2022
dlabrecq
approved these changes
Sep 6, 2022
andyyvo
pushed a commit
to andyyvo/patternfly-react
that referenced
this pull request
Sep 9, 2022
…patternfly#7941) * feat(resizeObserver): allow opting out of using requestAnimationFrame * Update examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7938
Additional issues:
Followup from discussion related to #7810