Skip to content

Conversation

@CodeDuchess
Copy link

@CodeDuchess CodeDuchess commented Dec 2, 2022

What: Closes #8211

Additional issues:

@patternfly-build
Copy link
Collaborator

patternfly-build commented Dec 2, 2022

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @CodeDuchess, this is a great start!

  • Can we update the PR title to match the syntax as recommended in our Developers Guide? E.g. fix(menu, select): added MenuToggle to props table. This format gives us a good idea of what to expect in the PR. You can do this by clicking the "Edit" button to the right of the title.

  • The issue number (#8211) can be moved to the description after "Closes". This will automatically close the corresponding issue once your PR is merged.

Left some code suggestions below as well, which will likely fix your build!

@nicolethoen
Copy link
Contributor

This issue might be blocked until patternfly/patternfly-org#3331 is addressed

@CodeDuchess CodeDuchess changed the title Menu toggle 8211 fix(menu, select): added MenuToggle to props table Jan 11, 2023
@nicolethoen
Copy link
Contributor

The unit tests here are failing because of a change made by a different contributor since you started working on this issue.
If you run these commands, it should fix the issue:

git fetch upstream
git rebase upstream/main
git push -f origin MenuToggle-8211

@CodeDuchess
Copy link
Author

@nicolethoen @jenny-s51 I think all necessary edits have been made. I am accustomed to GitLab, so I am still getting used to this UI. So forgive me if I have overlooked something. Thanks so much for your assistance!!

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is really close now @CodeDuchess!

If you click the "Commit Suggestion" and then "Commit changes" for each of those two comments above, it should fix your build.

Then this will be good to go once patternfly/patternfly-org#3331 is completed and merged.

CodeDuchess and others added 2 commits January 14, 2023 13:42
Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
…down.md

Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
@CodeDuchess
Copy link
Author

@jenny-s51 This PR is ready for merge and publish. Thanks so much for your guidance and patience!

@stale
Copy link

stale bot commented Apr 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Apr 1, 2023
@nicolethoen
Copy link
Contributor

Closing in favor of this issue being addressed in the v5 branch in the following PRs:
#8825
#8835

@nicolethoen nicolethoen closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dropdown next, Select next] - [add MenuToggle to props table]

5 participants