-
Notifications
You must be signed in to change notification settings - Fork 377
fix(menu, select): added MenuToggle to props table #8410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://patternfly-react-pr-8410.surge.sh A11y report: https://patternfly-react-pr-8410-a11y.surge.sh |
packages/react-core/src/next/components/Select/examples/Select.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @CodeDuchess, this is a great start!
-
Can we update the PR title to match the syntax as recommended in our Developers Guide? E.g.
fix(menu, select): added MenuToggle to props table. This format gives us a good idea of what to expect in the PR. You can do this by clicking the "Edit" button to the right of the title. -
The issue number (#8211) can be moved to the description after "Closes". This will automatically close the corresponding issue once your PR is merged.
Left some code suggestions below as well, which will likely fix your build!
packages/react-core/src/next/components/Dropdown/examples/Dropdown.md
Outdated
Show resolved
Hide resolved
|
This issue might be blocked until patternfly/patternfly-org#3331 is addressed |
|
The unit tests here are failing because of a change made by a different contributor since you started working on this issue. |
a31fc4a to
6a7ab98
Compare
|
@nicolethoen @jenny-s51 I think all necessary edits have been made. I am accustomed to GitLab, so I am still getting used to this UI. So forgive me if I have overlooked something. Thanks so much for your assistance!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is really close now @CodeDuchess!
If you click the "Commit Suggestion" and then "Commit changes" for each of those two comments above, it should fix your build.
Then this will be good to go once patternfly/patternfly-org#3331 is completed and merged.
Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
…down.md Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
|
@jenny-s51 This PR is ready for merge and publish. Thanks so much for your guidance and patience! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
What: Closes #8211
Additional issues: