feat(Select): Deprecated old select and promoted select next

[nicolethoen]

What: Closes #8073

hopefully to aid in review, the components, examples, and demos updated are linked below:

• Select examples are using the (formerly select-next) component
• Select deprecated examples
• CalendarMonth (uses a Select to build the month selector)
• LoginPage header utilities demo uses a select in the header
• Toolbar examples:
  • Groups
  • Consumer managed toggle groups
  • Component managed toggle groups
  • with filters
  • stacked
  • Console log viewer toolbar demo
• Tooltip example with options has two selects
• Card view demo has a select in the toolbar at the top
• Card demos:
  • Utilization card 3
  • Trend card 1
  • Log view
  • Events view
• Tabs "Tabs and table" Demo - replaced non-functional deprecated select with a menu toggle
• Table examples/demos:
  • Inline editable example - since its only in the legacy table, it still uses deprecated select
  • Column management demo - replaced non-functional deprecated select with a menu toggle
  • Column management with draggable demo - replaced non-functional deprecated select with a menu toggle
  • Filterable demo - this one has an alignment issue that I think is known when you add an icon to a menutoggle. Not sure what to do about that.
  • Compact demo - this demo's select filter opened and closed but did not update the contents of the table.
  • Compound expansion demo - this demo's select filter opened and closed but did not update the contents of the table.
  • Static bottom pagination demo - this demo's select filter opened and closed but did not update the contents of the table.

More updated examples after rebasing:
Table examples/demos:

• sortable with custom control
• deprecated sortable with custom control
• sortable responsive demo
• column management demo - replaced nonfunctional optionsmenu with a menutoggle

A few additional notes:

• I renamed the Select demos in the demo-app to Select Deprecated for clarity and updated the demos to import select
• There are a number of places where the existing deprecated select is representing a filter, but it was only partially implemented, or does not expand/collapse at all. In each case I replicated the existing behavior. If we want to update any of these demos to make them more fully functional, or more basic w/o functional filters, we can open a follow up issue.

[patternfly-build]

Preview: https://patternfly-react-pr-8825.surge.sh

A11y report: https://patternfly-react-pr-8825-a11y.surge.sh

[wise-king-sullyman]

Everything looks good to me once the CI issues are resolved.

[thatblindgeye]

Same as ☝🏼 , only have one comment below that isn't a blocker if we're able to get it in today

[mcarrano]

@nicolethoen @tlabaj The problem I have with this is that if I look at this from a consumer's perspective, it looks like we've taken a step back. The new default Select implementation has no documentation and on the surface looks to have very limited capability. I understand that the objective was to not reproduce all existing examples here and encourage use of the composable approach, but how would I know that here? I'm willing to help document and define additional examples that we should expose if you agree.

[tlabaj]

@nicolethoen @tlabaj The problem I have with this is that if I look at this from a consumer's perspective, it looks like we've taken a step back. The new default Select implementation has no documentation and on the surface looks to have very limited capability. I understand that the objective was to not reproduce all existing examples here and encourage use of the composable approach, but how would I know that here? I'm willing to help document and define additional examples that we should expose if you agree.

@mcarrano Yes, we can add more documentation here. What examples are we looking to add?

[nicolethoen]

could building out more examples/docs be a follow up issue here? @mcarrano @tlabaj

[mcarrano]

could building out more examples/docs be a follow up issue here? @mcarrano @tlabaj

I'm OK with that if you prefer, @nicolethoen . I can open an issue.

[mcarrano]

@nicolethoen I found two issue in my UX review:

1. For the Card demos with a plain select in the upper left of the card, the down caret is missing.

2. You notes that in the Filterable Table demo, the tool buttons misalign. That's true. But what I'm also seeing is that the Filter icon is incorrect. It should be like the one below. This seems to be consistently wrong everplace this icon is used. Not sure if that's what's also causing the misalignment, but the icon mismatch is concerning. Any idea what's going on there?

Here's what this looks like in the PR preview:

[nicolethoen]

@mcarrano when i look at patternfly.org's icons page, I see that there are two filter icons: https://www.patternfly.org/v4/guidelines/icons. One is the pf-icon filter, which is the one you see in the core and react workspaces's lists of icons. the one you're referring to is the font awesome filter icon, which I don't know how to specifically use rather than the pf icon.

[mcarrano]

@nicolethoen according to what's on the Icons page, we should be replacing using of pf-icon-filter with fa-filter.

This was correct previously when using FilterIcon from React, so what changed? @mcoker any idea?

[nicolethoen]

@mcarrano i've opened the following issue to note the discrepancy so we don't hold up this PR

[evwilkin]

@nicolethoen put up a fix for the filter icon here - #8920

It's a small change so if you prefer to add it to this PR and close out mine go for it, otherwise my PR can compliment this one to fix the issue - it's unrelated to your changes here and comes from a prior Core bump PR.

[nicolethoen]

@evwilkin I'll leave your changes in your PR

[mcarrano]

Whatever can be going on here? https://patternfly-react-pr-8825.surge.sh/components/card/react-demos/#utilization-card-3

[tlabaj]

Whatever can be going on here? https://patternfly-react-pr-8825.surge.sh/components/card/react-demos/#utilization-card-3

@mcarrano this issue was introduced prior to this PR. We can you open a separate issue to look into it

[mcarrano]

That sounds good @tlabaj . If you can open that issue, I will go ahead and approve this as it otherwise looks good.

[tlabaj]

@mcarrano issue opened #8936

[mcarrano]

@tlabaj thanks for opening the issue. In that case, this PR looks good to go.

[patternfly-build]

Your changes have been released in:

• @patternfly/react-code-editor@5.0.0-alpha.64
• @patternfly/react-core@5.0.0-alpha.63
• @patternfly/react-docs@6.0.0-alpha.69
• demo-app-ts@5.0.0-alpha.47
• @patternfly/react-integration@5.0.0-alpha.23
• @patternfly/react-table@5.0.0-alpha.65

Thanks for your contribution! 🎉