Workflow optimizations#980
Closed
benalleng wants to merge 6 commits intopayjoin:masterfrom
Closed
Conversation
benalleng
force-pushed
the
workflow-optimizations
branch
7 times, most recently
from
a15623a to
05d9043
Compare
DanGould
reviewed
Aug 20, 2025
Comment on lines
-8
to
-10
| # Run each script | ||
| scripts/generate_linux.sh | ||
| scripts/generate_macos.sh |
Contributor
There was a problem hiding this comment.
This removes the dependency on these scripts but not the scripts themselves. Why not?
Couldn't this conditionally call out to those scripts instead as well?
Collaborator
Author
There was a problem hiding this comment.
Still working on optimizing the script, wanted them as reference still within my local branch as I am still referring back to them
benalleng
force-pushed
the
workflow-optimizations
branch
22 times, most recently
from
c66e9b0 to
99f1312
Compare
benalleng
force-pushed
the
workflow-optimizations
branch
3 times, most recently
from
c4c742c to
b6a77df
Compare
Collaborator
Author
|
unblocked by #986 |
benalleng
force-pushed
the
workflow-optimizations
branch
from
b6a77df to
c493713
Compare
Collaborator
Pull Request Test Coverage Report for Build 17134606157Details
💛 - Coveralls |
benalleng
force-pushed
the
workflow-optimizations
branch
from
62d2cdb to
56ba59f
Compare
benalleng
force-pushed
the
workflow-optimizations
branch
from
56ba59f to
f683f8f
Compare
benalleng
force-pushed
the
workflow-optimizations
branch
from
2c7bb9b to
370f957
Compare
This was referenced Aug 21, 2025
Collaborator
Author
|
The smaller PRs have been opened |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please confirm the following before requesting review: