Optimize the workflow for dart CI#988
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Aug 21, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 17137104182Details
💛 - Coveralls |
benalleng
force-pushed
the
dart-workflow-optimize
branch
2 times, most recently
from
15a2e31 to
a6b923e
Compare
spacebear21
approved these changes
Aug 21, 2025
Collaborator
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
Concept ACK, I have some minor suggestions
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-13] | ||
| os: [ubuntu-latest, macos-15] |
Collaborator
There was a problem hiding this comment.
I think we could use macos-latest?
Comment on lines
+27
to
+28
| cargo build --features _test-utils --profile release | ||
| cargo run --features _test-utils --profile release --bin uniffi-bindgen -- --library target/release/$LIBNAME --language dart --out-dir dart/lib/ |
Collaborator
There was a problem hiding this comment.
This step appears to be the same regardless of the platform, could likely be moved before the if?
| chmod +x ./scripts/generate_linux.sh | ||
| chmod +x ./scripts/generate_macos.sh | ||
| OS=$(uname -s) | ||
| ARCH=$(uname -m) |
Collaborator
There was a problem hiding this comment.
Looks like ARCH is no longer needed
Comment on lines
+15
to
+18
| if [[ "$OS" == "Darwin" ]]; then | ||
| LIBNAME=$MAC_LIBNAME | ||
| elif [[ "$OS" == "Linux" ]]; then | ||
| LIBNAME=$LINUX_LIBNAME |
Collaborator
There was a problem hiding this comment.
Suggested change
| if [[ "$OS" == "Darwin" ]]; then | |
| LIBNAME=$MAC_LIBNAME | |
| elif [[ "$OS" == "Linux" ]]; then | |
| LIBNAME=$LINUX_LIBNAME | |
| if [[ "$OS" == "Darwin" ]]; then | |
| LIBNAME=libpayjoin_ffi.dylib | |
| elif [[ "$OS" == "Linux" ]]; then | |
| LIBNAME=libpayjoin_ffi.so |
Collaborator
There was a problem hiding this comment.
nit: I'd name this generate_bindings.sh or something more plain english
benalleng
force-pushed
the
dart-workflow-optimize
branch
from
a6b923e to
a1ee3a8
Compare
spacebear21
reviewed
Aug 21, 2025
| # Skip integration test on macOS due to Docker issues | ||
| run: | | ||
| if [ "${{ matrix.os }}" = "macos-13" ]; then | ||
| if [ "${{ matrix.os }}" = "macos-15" ]; then |
Collaborator
There was a problem hiding this comment.
Suggested change
| if [ "${{ matrix.os }}" = "macos-15" ]; then | |
| if [ "${{ matrix.os }}" = "macos-latest" ]; then |
Collaborator
Author
There was a problem hiding this comment.
i think that macos-latest on matrix.os returns a specific version in this case macos-14 until the end of the month when it will transition to macos-15. not 100% on this though
Collaborator
Author
There was a problem hiding this comment.
nvm you're right
benalleng
force-pushed
the
dart-workflow-optimize
branch
from
a1ee3a8 to
58836ae
Compare
This is a simplification for the dart build and test workflow for linux and macos
benalleng
force-pushed
the
dart-workflow-optimize
branch
from
58836ae to
ab7fa2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simplification for the dart build and test workflow for linux and macos
This is the part 1 to split up #980 into more manageable chunks
Pull Request Checklist
Please confirm the following before requesting review: