Fix: Duplicate bulk deletion notifications

[hallo123wert]

Followup for #1877

[coderabbitai]

📝 Walkthrough

Walkthrough

Added suppression of the success notification title for the bulk delete action on the files listing by setting the action's successNotificationTitle to null; no other behavior or authorization was changed.

Changes

Cohort / File(s)	Summary
Suppress Bulk Delete Success Title app/Filament/Server/Resources/Files/Pages/ListFiles.php	Updated the bulk delete action invocation to call ->successNotificationTitle(null) on DeleteBulkAction::make(), preventing a success notification title from being shown; all deletion logic and authorization remain unchanged.

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the fix applied: suppressing duplicate bulk deletion notifications through successNotificationTitle(null).
Description check	✅ Passed	The description references a related issue (#1877), which provides context for the fix being applied in this followup PR.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8fabd3c and 90da025.

📒 Files selected for processing (1)

• app/Filament/Server/Resources/Files/Pages/ListFiles.php (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• app/Filament/Server/Resources/Files/Pages/ListFiles.php

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/Filament/Server/Resources/Files/Pages/ListFiles.php (1)

447-466: Missing confirmation dialog for bulk file deletion.

The switch from DeleteBulkAction to BulkAction resolves the duplicate notification issue, but removes the built-in confirmation that DeleteBulkAction provided. The bulk delete action requires an explicit requiresConfirmation() call, which is currently missing. Filament's BulkAction fully supports this method.

Add confirmation to match the single record delete at line 362:

                    BulkAction::make('delete selected')
                        ->color('danger')
                        ->icon('heroicon-o-trash')
                        ->authorize(fn () => user()?->can(Permission::ACTION_FILE_DELETE, $server))
+                        ->requiresConfirmation()
                        ->action(function (Collection $files) {

🧹 Nitpick comments (1)

app/Filament/Server/Resources/Files/Pages/ListFiles.php (1)

447-449: Icon inconsistency with single delete action.

The bulk delete action uses heroicon-o-trash while the single record delete action at line 361 uses tabler-trash. For visual consistency, consider using the same icon family throughout.

Apply this diff to align with the existing icon style:

                    BulkAction::make('delete selected')
                        ->color('danger')
-                        ->icon('heroicon-o-trash')
+                        ->icon('tabler-trash')
                        ->authorize(fn () => user()?->can(Permission::ACTION_FILE_DELETE, $server))

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c3b091 and 8fabd3c.

📒 Files selected for processing (1)

• app/Filament/Server/Resources/Files/Pages/ListFiles.php (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-09-16T19:30:21.443Z

Learnt from: rmartinoscar
Repo: pelican-dev/panel PR: 1708
File: app/Filament/App/Resources/Servers/Pages/ListServers.php:115-116
Timestamp: 2025-09-16T19:30:21.443Z
Learning: The Filament `recordActions` method accepts both arrays and ActionGroup instances (signature: `array | ActionGroup $actions`), so ActionGroup can be passed directly without wrapping in an array.

Applied to files:

• app/Filament/Server/Resources/Files/Pages/ListFiles.php

📚 Learning: 2025-09-16T19:32:01.343Z

Learnt from: rmartinoscar
Repo: pelican-dev/panel PR: 1708
File: app/Filament/App/Resources/Servers/Pages/ListServers.php:228-266
Timestamp: 2025-09-16T19:32:01.343Z
Learning: ActionGroup in Filament automatically hides itself when all child actions are not visible, so additional hidden() logic to prevent empty groups is unnecessary.

Applied to files:

• app/Filament/Server/Resources/Files/Pages/ListFiles.php

[hallo123wert]

I have read the CLA Document and I hereby sign the CLA

[notAreYouScared]

Please follow the some fix i used for the original pr

[Boy132]

Thank you for your contribution!