-
-
Notifications
You must be signed in to change notification settings - Fork 254
Fix schedule actions #1992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix schedule actions #1992
Conversation
the edit view is the first view and view requires a url edit to see the run now button..
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughCentralizes the DeleteAction icon in FilamentServiceProvider, removes explicit Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FilamentUI as Filament (UI)
participant Auth as Authorization
participant TenantCtx as Filament Facade (tenant)
participant ProcessSvc as ProcessScheduleService
participant ActivityLog as Activity
participant Form as Schedule Form
User->>FilamentUI: Click "Run Now" (run_now action)
FilamentUI->>TenantCtx: resolve current tenant & schedule
FilamentUI->>Auth: check SubuserPermission::ScheduleUpdate for tenant
Auth-->>FilamentUI: authorized / denied
alt authorized
FilamentUI->>ProcessSvc: ProcessScheduleService::handle(schedule, true)
ProcessSvc-->>FilamentUI: success / failure
FilamentUI->>ActivityLog: record "server:schedule.execute" with schedule name
FilamentUI->>Form: fillForm() (refresh)
FilamentUI-->>User: update UI (toast/state)
else denied
FilamentUI-->>User: show authorization error
end
Possibly related PRs
Pre-merge checks❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No reason to have it, acts like a back button...
Move
Run Nowto edit the page, as it's the first page when a schedule is editable.Fixed the delete action icon missing.