Skip to content

Break off main function to make module importable#12

Merged
pengbo0328 merged 2 commits intopgpool:masterfrom
odenio:modit
Feb 7, 2022
Merged

Break off main function to make module importable#12
pengbo0328 merged 2 commits intopgpool:masterfrom
odenio:modit

Conversation

@n-oden
Copy link
Contributor

@n-oden n-oden commented Dec 15, 2021

Also update reqs to go 1.17 and apply gofmt.

This should resolve #4

@n-oden
Copy link
Contributor Author

n-oden commented Jan 20, 2022

Hey @pengbo0328 any thoughts on this and #11 ?

@pengbo0328
Copy link
Collaborator

Thank you!

Could you update "Building and running" section of README.md to describe how to create and run the binary?

Also update reqs to go 1.17 and apply gofmt.

This should resolve #4
@n-oden
Copy link
Contributor Author

n-oden commented Jan 25, 2022

@pengbo0328 I've taken another pass at this. The instructions in the README should still be correct: make should create the binary in the top of the repo.

@pengbo0328
Copy link
Collaborator

@n-oden Thank you! It works and the the binary is created in the top of the repo now.
Do you think we should rename file cmd/pgpool2_exporter/pgpool2_exporter.go to other name?

@n-oden
Copy link
Contributor Author

n-oden commented Feb 4, 2022

@pengbo0328 good idea -- all done now!

@pengbo0328
Copy link
Collaborator

@n-oden Thank you!

@pengbo0328 pengbo0328 merged commit fba2811 into pgpool:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request to make the exporter a golang package

2 participants