Skip to content
This repository was archived by the owner on Aug 17, 2025. It is now read-only.

Pull request on master from forked release branch#134

Closed
andrewscaya wants to merge 3 commits into
phly:masterfrom
andrewscaya:release
Closed

Pull request on master from forked release branch#134
andrewscaya wants to merge 3 commits into
phly:masterfrom
andrewscaya:release

Conversation

@andrewscaya
Copy link
Copy Markdown
Contributor

@andrewscaya andrewscaya commented May 23, 2016

This release:

  1. Updates all references to the deprecated Zend\Stdlib\Hydrator classes.
  2. Replaces all occurrences of the EventManager's triggerUntil method (deprecated) with its trigger method,
  3. Modifies a method declaration for consistency.

weierophinney
weierophinney reviewed May 24, 2016
View reviewed changes
Comment thread src/PhlyRestfully/Resource.php
$events = $this->getEventManager();
$event = $this->prepareEvent(__FUNCTION__, array('data' => $data));
$results = $events->triggerUntil($event, function($result) {
$results = $events->trigger($event, function($result) {
Copy link
Copy Markdown
Contributor

@weierophinney weierophinney May 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be triggerEventUntil() to be forwards compatible.

Copy link
Copy Markdown
Contributor

@weierophinney weierophinney May 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment applies to all trigger() statements below.

@weierophinney
Copy link
Copy Markdown
Contributor

weierophinney commented May 24, 2016

This also needs:

  • to update composer.json to add zendframework/zend-hydrator: ^1.1 as a requirement.
  • to update composer.json to mark PHP as ^5.5 || ^7.0; I'd also argue all ZF components should be updated to read ^2.5, and PHPUnit as ^4.8.
  • to update the .travis.yml to add PHP 5.5, 5.6, and 7.0 as supported versions. We can remove 5.3 and 5.4 from the support matrix.

Make these changes, along with the code changes already suggested, and I'll re-review.

Thanks, @andrewscaya !

weierophinney added a commit that referenced this pull request May 26, 2016
@weierophinney
Merge branch 'feature/135' into develop
86bf861 
Close #135
Fixes #134
Fixes #133
Fixes #132
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewscaya @weierophinney