This repository was archived by the owner on Aug 17, 2025. It is now read-only.
Pull request on master from forked release branch#135
Closed
andrewscaya wants to merge 7 commits into
Closed
Conversation
…eprecated) with its triggerEventUntil method (forwards compatible).
…dded a requirement for the Zend Hydrator component.
…and 5.4 from the support matrix.
…space for the Zend Hydrator classes) and a couple of errors concerning a missing argument to the ControllerManager's constructor.
| } | ||
|
|
||
| public function deleteList() | ||
| public function deleteList($data = []) |
Contributor
There was a problem hiding this comment.
This needs to be a required parameter, as zend-mvc made it required in 2.2 or 2.3, IIRC. I'll write a test to check, and, of so, update it during merge.
Contributor
There was a problem hiding this comment.
Forgot that removing arguments follows the LSP, so this works fine.
weierophinney
added a commit
that referenced
this pull request
May 26, 2016
Pull request on master from forked release branch
weierophinney
added a commit
that referenced
this pull request
May 26, 2016
weierophinney
added a commit
that referenced
this pull request
May 26, 2016
Contributor
|
Merged to develop for release with 2.3.0 (which will be within the next hour or so) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release: