Skip to content

Conversation

@johnbillion
Copy link
Contributor

@johnbillion johnbillion commented Aug 9, 2022

Fixes #46. Needs testing.

Todo

  • Check each of the ~60 additions to ensure they're correct
  • Add inline docs so our future selves are thankful

@szepeviktor
Copy link
Member

strpos($description, '()')

Very clever.

@johnbillion
Copy link
Contributor Author

This is looking good and we're green ✅ but I want to manually check each of the additions to ensure their correctness because there is an allowance for the parameter names to differ from its inherited function, which could in theory result in the wrong parameter being used.

@johnbillion johnbillion marked this pull request as ready for review August 10, 2022 23:26
johnbillion and others added 2 commits August 15, 2022 18:08
Co-authored-by: Viktor Szépe <viktor@szepe.net>
@szepeviktor
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand $args array parameters that are described in other functions

2 participants