Synchronize ext/dom class synopses with stubs based on PHP 8.3 changes#2890
Merged
Conversation
kocsismate
force-pushed
the
stub-sync-dom
branch
from
2561927 to
321a4ec
Compare
kocsismate
force-pushed
the
stub-sync-dom
branch
from
321a4ec to
cb1e77e
Compare
Member
|
Duplicate of #2813? |
Member
Author
|
Nope, fortunately this one synchronizes the class synopses. 🙂 |
ndossche
requested changes
Oct 28, 2023
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Thank you for working on this Máté!
I have some remarks and description suggestions 🙂
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
kocsismate
changed the title
kocsismate
force-pushed
the
stub-sync-dom
branch
from
f74fda4 to
8ab84b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most descriptions are empty, so I'm happy to receive suggestions :)