Skip to content

Synchronize ext/dom class synopses with stubs based on PHP 8.3 changes #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Girgias merged 5 commits into from
Oct 29, 2023
Merged

Synchronize ext/dom class synopses with stubs based on PHP 8.3 changes #2890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb1e77e
Synchronize ext/dom with the stubs based on the PHP 8.3 changes
kocsismate Oct 28, 2023
f343816
Update reference/dom/domnode.xml
kocsismate Oct 29, 2023
c2a3460
Update reference/dom/domelement.xml
kocsismate Oct 29, 2023
dff799a
Update reference/dom/domnode.xml
kocsismate Oct 29, 2023
8ab84b1
Remove constants introduced in PHP 8.4
kocsismate Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion reference/dom/domdocument.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@
<modifier>readonly</modifier>
<type>mixed</type>
<varname linkend="domdocument.props.config">config</varname>
<initializer>null</initializer>
</fieldsynopsis>
<fieldsynopsis>
<modifier>public</modifier>
Expand Down
22 changes: 22 additions & 0 deletions reference/dom/domelement.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,16 @@
<type>string</type>
<varname linkend="domelement.props.tagname">tagName</varname>
</fieldsynopsis>
<fieldsynopsis>
<modifier>public</modifier>
<type>string</type>
<varname linkend="domelement.props.classname">className</varname>
</fieldsynopsis>
<fieldsynopsis>
<modifier>public</modifier>
<type>string</type>
<varname linkend="domelement.props.id">id</varname>
</fieldsynopsis>
<fieldsynopsis>
<modifier>public</modifier>
<modifier>readonly</modifier>
Expand Down Expand Up @@ -153,6 +163,18 @@
<para>The element name</para>
</listitem>
</varlistentry>
<varlistentry xml:id="domelement.props.classname">
<term><varname>className</varname></term>
<listitem>
<para>A string representing the classes of the element separated by spaces</para>
</listitem>
</varlistentry>
<varlistentry xml:id="domelement.props.id">
<term><varname>id</varname></term>
<listitem>
<para>The element ID</para>
</listitem>
</varlistentry>
</variablelist>
</section>
<!-- }}} -->
Expand Down
31 changes: 31 additions & 0 deletions reference/dom/domnode.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@
<type class="union"><type>DOMNode</type><type>null</type></type>
<varname linkend="domnode.props.parentnode">parentNode</varname>
</fieldsynopsis>
<fieldsynopsis>
<modifier>public</modifier>
<modifier>readonly</modifier>
<type class="union"><type>DOMElement</type><type>null</type></type>
<varname linkend="domnode.props.parentelement">parentElement</varname>
</fieldsynopsis>
<fieldsynopsis>
<modifier>public</modifier>
<modifier>readonly</modifier>
Expand Down Expand Up @@ -84,6 +90,12 @@
<type class="union"><type>DOMNamedNodeMap</type><type>null</type></type>
<varname linkend="domnode.props.attributes">attributes</varname>
</fieldsynopsis>
<fieldsynopsis>
<modifier>public</modifier>
<modifier>readonly</modifier>
<type>bool</type>
<varname linkend="domnode.props.isconnected">isConnected</varname>
</fieldsynopsis>
<fieldsynopsis>
<modifier>public</modifier>
<modifier>readonly</modifier>
Expand Down Expand Up @@ -161,6 +173,12 @@
<para>The parent of this node. If there is no such node, this returns &null;.</para>
</listitem>
</varlistentry>
<varlistentry xml:id="domnode.props.parentelement">
<term><varname>parentElement</varname></term>
<listitem>
<para>The parent element of this element. If there is no such element, this returns &null;.</para>
</listitem>
</varlistentry>
<varlistentry xml:id="domnode.props.childnodes">
<term><varname>childNodes</varname></term>
<listitem>
Expand Down Expand Up @@ -214,6 +232,12 @@
</para>
</listitem>
</varlistentry>
<varlistentry xml:id="domnode.props.isconnected">
<term><varname>isConnected</varname></term>
<listitem>
<para>Whether the node is connected to a document</para>
</listitem>
</varlistentry>
<varlistentry xml:id="domnode.props.ownerdocument">
<term><varname>ownerDocument</varname></term>
<listitem>
Expand Down Expand Up @@ -268,6 +292,13 @@
</row>
</thead>
<tbody>
<row>
<entry>8.3.0</entry>
Comment thread
kocsismate marked this conversation as resolved.
Outdated
<entry>
Properties <property>DOMNode::$parentElement</property>, and
<property>DOMNode::$isConnected</property> have been added.
</entry>
</row>
<row>
<entry>8.0.0</entry>
<entry>
Expand Down