Skip to content

fix parsing tokens on PHP 8#114

Merged
jaapio merged 1 commit intophpDocumentor:1.xfrom
xabbuh:php8-namespace-tokens
Sep 17, 2020
Merged

fix parsing tokens on PHP 8#114
jaapio merged 1 commit intophpDocumentor:1.xfrom
xabbuh:php8-namespace-tokens

Conversation

@xabbuh
Copy link
Copy Markdown
Contributor

@xabbuh xabbuh commented Sep 8, 2020

No description provided.

@xabbuh
Copy link
Copy Markdown
Contributor Author

xabbuh commented Sep 8, 2020

The ContextFactoryTest currently fails on PHP 8 due to php/php-src@7a3dcc3 (see also phpDocumentor/ReflectionDocBlock#248).

@jaapio jaapio merged commit f598aec into phpDocumentor:1.x Sep 17, 2020
@jaapio
Copy link
Copy Markdown
Member

jaapio commented Sep 17, 2020

Thanks for this contribution 👍

I merged your PR and improved the implementation a bit

@xabbuh xabbuh deleted the php8-namespace-tokens branch September 18, 2020 07:54
@xabbuh
Copy link
Copy Markdown
Contributor Author

xabbuh commented Sep 18, 2020

Thank you @jaapio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants