Fixes to make CI green#96
Conversation
|
Woah, so cool! Thanks a lot for this PR! |
Perfect timing, I just finished (: Do review it please, though! Some comments/questions:
|
I did review it! Really good job 👍
Definitely, it would make sense for the next minor version!
That would be awesome. But we can save that for another PR.
Let's keep it for now. There was a trick where I was uninstalling the "security bundle" and running tests again to test the behaviour of the graphqlite-bundle when there is no security bundle. We should probably reproduce that at some point. |
| /** | ||
| * @Field | ||
| */ | ||
| public function getUserName(UserInterface $user): string |
There was a problem hiding this comment.
Are we expecting to rename this to getUserIdentifier in a future (breaking) release?
Several fixes:
None of this should be a breaking change
++ Some of this version bumps should go into the graphqlite package! – I can create a PR there later, but it doesn't hurt to have them here as well