Skip to content

Comments

Smooth out the animated tile transitions in home feed#270

Merged
RanaBug merged 1 commit intostagingfrom
fix/PRO-3155/empty-home-feed-tiles
Mar 25, 2025
Merged

Smooth out the animated tile transitions in home feed#270
RanaBug merged 1 commit intostagingfrom
fix/PRO-3155/empty-home-feed-tiles

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented Mar 25, 2025

Description

  • Smooth out the animation when tiles appears in the home feed to avoid any "jumping" effect

How Has This Been Tested?

  • Manual Testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

  • Style
    • Improved the animated tile’s transition behavior for a smoother, more natural entrance as it comes into view.

@RanaBug RanaBug requested a review from IAmKio March 25, 2025 16:59
@RanaBug RanaBug self-assigned this Mar 25, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2025

Walkthrough

The changes adjust the animation behavior of the AnimatedTile component. The useInView hook parameters now use an increased threshold (from 0.1 to 0.2) and a reduced rootMargin (from '100px 0px 0px 0px' to '75px 0px 0px 0px'). Additionally, the useSpring hook's transform property is updated to shift from 'translateY(100px)' to 'translateY(50px)', altering the animated entrance when the component comes into view.

Changes

File(s) Change Summary
src/apps/.../AnimatedTitle.tsx Updated useInView hook parameters: threshold increased to 0.2; rootMargin adjusted to '75px 0px 0px 0px'. Updated useSpring hook: transform changed from 'translateY(100px)' to 'translateY(50px)'.

Sequence Diagram(s)

sequenceDiagram
    participant AT as AnimatedTile
    participant IV as useInView Hook
    participant AS as useSpring Animation

    AT->>IV: Check visibility (threshold: 0.2, rootMargin: '75px 0px 0px 0px')
    IV-->>AT: Return in-view status
    AT->>AS: Trigger animation (transform: 'translateY(50px)')
    AS-->>AT: Animate component into view
Loading

Suggested reviewers

  • IAmKio

Poem

I'm a bunny with a keen code eye,
Hopping through changes as the values fly.
Thresholds raised and margins trimmed so neat,
Animated journeys now have a lighter beat.
A joyful hop in every line of code so sweet!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d0e822 and 93301a6.

📒 Files selected for processing (1)
  • src/apps/pillarx-app/components/AnimatedTile/AnimatedTitle.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: unit-tests
  • GitHub Check: build
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
src/apps/pillarx-app/components/AnimatedTile/AnimatedTitle.tsx (2)

35-36: Nice adjustment to the useInView parameters.

Increasing the threshold from 0.1 to 0.2 means the animation will trigger when more of the tile is visible, while reducing the rootMargin from 100px to 75px makes the detection zone closer to the actual viewport. These changes should help prevent premature animations, reducing the jumping effect mentioned in the PR objectives.


56-56: Great improvement to the animation smoothness.

Reducing the vertical translation from 100px to 50px is a smart change that makes the animation more subtle and less jarring. This directly addresses the PR goal of eliminating the "jumping" effect during transitions while still maintaining a noticeable and elegant entrance animation.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cloudflare-workers-and-pages
Copy link

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 93301a6
Status: ✅  Deploy successful!
Preview URL: https://90f1338f.x-e62.pages.dev
Branch Preview URL: https://fix-pro-3155-empty-home-feed.x-e62.pages.dev

View logs

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RanaBug RanaBug merged commit b093137 into staging Mar 25, 2025
7 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 26, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants