Skip to content

Comments

fix jumpy effect on tiles#271

Merged
RanaBug merged 1 commit intostagingfrom
fix/PRO-3155/empty-home-feed-tiles
Mar 26, 2025
Merged

fix jumpy effect on tiles#271
RanaBug merged 1 commit intostagingfrom
fix/PRO-3155/empty-home-feed-tiles

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented Mar 26, 2025

Description

  • Fix jumpy effect when tiles disappear from the screen

How Has This Been Tested?

  • Manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

  • Style
    • Enhanced scroll-triggered animations with refined transition thresholds and movement effects, resulting in a smoother, more visually engaging experience when content appears on screen.

@RanaBug RanaBug requested a review from IAmKio March 26, 2025 10:26
@RanaBug RanaBug self-assigned this Mar 26, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 26, 2025

Walkthrough

This pull request updates the animation behavior of the AnimatedTile component. The rootMargin parameter in the useInView hook has been changed from '75px 0px 0px 0px' to '100px 0px 0px 0px', and the transform property in the useSpring hook has been updated from 'translateY(50px)' to 'translateY(75px)'. These modifications adjust the visibility detection threshold and the animation transition effect. No changes have been made to exported or public entities.

Changes

File Path Change Summary
src/.../AnimatedTitle.tsx Updated useInView hook’s rootMargin from '75px 0px 0px 0px' to '100px 0px 0px 0px' and modified useSpring hook’s transform from 'translateY(50px)' to 'translateY(75px)'.

Possibly related PRs

Suggested reviewers

  • IAmKio

Poem

I'm a rabbit hopping through the code day by day,
Tweaking hooks and margins in a merry, quaint way.
Shifting views with a gentle push, watch the tile dance,
Translating its spring with a fresh, bold stance.
Celebrating each change with a joyful leap and cheer,
For smoother animations that all users now endear!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a1a4e2 and 1f6798a.

📒 Files selected for processing (1)
  • src/apps/pillarx-app/components/AnimatedTile/AnimatedTitle.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: unit-tests
  • GitHub Check: build
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (3)
src/apps/pillarx-app/components/AnimatedTile/AnimatedTitle.tsx (3)

34-36: Animation threshold adjustment looks good.

Increasing the rootMargin from '75px' to '100px' means elements will be detected as "in view" earlier while scrolling. This gives the animation more time to complete smoothly before the tile becomes fully visible, which should help reduce the jumpiness.


54-56: Increased animation distance complements the earlier detection.

Increasing the transform distance from 50px to 75px creates a longer animation path. Combined with the earlier detection from the increased rootMargin, this should create a smoother transition as tiles enter the viewport.


34-64:

Details

❓ Verification inconclusive

Verify that the animation timing feels natural across devices.

The changes work together to address the jumpy effect, but animation feel can vary across devices with different screen sizes and performance characteristics. Consider testing on various devices to ensure the timing and animation distance feel natural in all scenarios.


🏁 Script executed:

#!/bin/bash
# Check if there are any related issues or PRs about animation performance
echo "Checking for related issues about animation performance..."
rg -i "animation|jumpy|smooth|spring|tile" .github/ISSUE_TEMPLATE/

Length of output: 259


Action Needed: Manually Confirm Animation Performance on Multiple Devices

The current implementation uses the intersection observer and react-spring effectively to trigger the animation and record user presence once the animation completes. However, as animation performance can vary dramatically based on device specs and screen sizes, please ensure that the 75px translate and the spring configuration (tension: 170, friction: 26) produce smooth, natural transitions on a range of devices—from lower-end to high-performance models.

  • Test on multiple devices: Verify that the animation timing and distance feel natural on various devices and screen resolutions.
  • Monitor for any jankiness: Even if the code is functionally correct, subtle differences in hardware performance might affect the visual smoothness.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-workers-and-pages
Copy link

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f6798a
Status: ✅  Deploy successful!
Preview URL: https://f5d27a02.x-e62.pages.dev
Branch Preview URL: https://fix-pro-3155-empty-home-feed.x-e62.pages.dev

View logs

@RanaBug RanaBug merged commit ae117e2 into staging Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants